Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 67882 invoked from network); 9 Aug 2004 23:32:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 9 Aug 2004 23:32:21 -0000 Received: (qmail 94038 invoked by uid 500); 9 Aug 2004 23:32:19 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 93865 invoked by uid 500); 9 Aug 2004 23:32:17 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 93789 invoked by uid 99); 9 Aug 2004 23:32:17 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [195.154.174.52] (HELO mail.logilune.com) (195.154.174.52) by apache.org (qpsmtpd/0.27.1) with ESMTP; Mon, 09 Aug 2004 16:32:15 -0700 Received: from [127.0.0.1] (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id 9E1C11E1E4C; Tue, 10 Aug 2004 01:32:12 +0200 (CEST) Message-ID: <4118097B.9080408@stason.org> Date: Mon, 09 Aug 2004 16:32:11 -0700 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040708 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 To: "Philippe M. Chiasson" Cc: dev@perl.apache.org Subject: Re: Filter and Handlers should not reset $@ if it was set before entering References: <4117E3CD.1060404@ectoplasm.org> <4117E937.8020406@stason.org> <4117ECCC.5050907@ectoplasm.org> <4117F1E5.5010402@stason.org> <4117F338.1020604@ectoplasm.org> <4117F5E7.206@ectoplasm.org> <4117F980.2090405@stason.org> <411802CF.60001@ectoplasm.org> In-Reply-To: <411802CF.60001@ectoplasm.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Philippe M. Chiasson wrote: > > > Stas Bekman wrote: > >>>> Yes, this $@ save/restore logic could be added to filters only. But, >>>> still, >>>> in the case of a failing response handler & filter handler, you'd >>>> lose the >>>> error from the filter. >>> >>> >>> >>> At least, here is a patch that does the same thing, but only for >>> filters. >> >> >> >> The problem with filters is that Apache has no provision for error >> handling. So may be we should at least Perl_warn it, before restoring >> ERRSV? > > > Attached patch moves $@ save/restoring to filter logic only, and does warn > in the case of a filter error detected while there was already another > known > error before entering the filter I guess it works for now. I thought that we could still possibly localize $@ at some point. In any case it looks good, but I'd like to see the added craft wrapped into 2 macros, since it makes the code less readable in the expanded form. Thanks. Feel free to call those macros in either way you prefer. >>>> Maybe we need to be smarter about this a bit and somehow concatenate >>>> the >>>> errors ? >> >> >> >> Sounds like a good idea. But may be later. > > > Something like APR::Error supporting aggregated errors maybe ? May be, I haven't given it any thought. Trying to juggle too many issue at once... -- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org