Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <4112CCFB.5040202@modperlcookbook.org>
Date: Thu, 05 Aug 2004 20:12:43 -0400
From: Geoffrey Young <geoff@modperlcookbook.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
MIME-Version: 1.0
To: Stas Bekman <stas@stason.org>
CC: dev@perl.apache.org, joe+gmane@sunstarsys.com
Subject: Re: apr core dumps with 2.1
References: <4112805A.5030103@modperlcookbook.org>
 <87k6wd9zu8.fsf@gemini.sunstarsys.com> <41129D35.4020800@modperlcookbook.org>
 <4112C67B.7080208@stason.org>
In-Reply-To: <4112C67B.7080208@stason.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit


> Are you sure that httpd_version_as_int is the right method to decide
> which apr is used? 

nope, and now that you mention it, it certainly assumes you got apr from httpd.

> Is there a better way?

I can't think of one, but I obviously don't have my apr chops lately.  but
you're right, we should make it apr-specific and not httpd-specific if at
all possible.

> 
> +1,
> 
> but after you commit we need to refactor the obvious dups (4 in your
> patch):

ok, commit first then refactor.

> into one place, preferrably in Apache::Build, e.g. so that they are
> callable as:
> 
> $build->apr_util
> $build->apu_util

$build->apr_config and $build->apu_config?  that is, if the call is supposed
to return the path to tbe binary.

> If you don't have the time, commit your patch and I'll refactor it next.
> I want to do some extra refactoring on the libs stuff.

if you have a clear picture of what you want the refactoring to look like,
I'll just let you handle it after we get it working again.  if you don't
care, I'll give it a whirl.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org