perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: [mp2] building aprext
Date Sun, 01 Aug 2004 19:29:04 GMT
On Sun, 1 Aug 2004, Stas Bekman wrote:

> Randy Kobes wrote:
> > On Sun, 1 Aug 2004, Stas Bekman wrote:
> >
> >
> >>Randy Kobes wrote:
> >>
> >>>I've attached a patch (as it includes tabs) for building the
> >>>static aprext lib for Win32 (and perhaps others) when need
> >>>be in providing symbols to APR/APR::* so as to be usable
> >>>outside of mod_perl.so.
> >
> > [ ... ]
> >
> >>Nice work, Randy
> >>
> >>The only comment I have is that there is a lot of code
> >>duplication going on in Makefile.PL. It think it should be
> >>abstracted into a sub.
> >
> > Thanks, Stas - that's a good idea. In the attached, I put
> > the code to get the directory and name of the built aprext
> > lib into an Apache::Build sub.
>
> Excellent.
>
> > Index: xs/APR/APR/Makefile.PL
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/xs/APR/APR/Makefile.PL,v
> > retrieving revision 1.25
> > diff -u -r1.25 Makefile.PL
> > --- xs/APR/APR/Makefile.PL	4 Jul 2004 18:44:49 -0000	1.25
> > +++ xs/APR/APR/Makefile.PL	1 Aug 2004 18:00:02 -0000
> > @@ -9,6 +9,7 @@
> >  use File::Spec::Functions;
> >
> >  use constant WIN32   => Apache::Build::WIN32;
> > +use constant BUILD_APREXT   => Apache::Build::BUILD_APREXT;
> >  use constant SOLARIS => $^O eq 'solaris';
>
> I'd swap the constants here, keeping the OS aliases together.
>
> Now, the AIX stuff... we don't know whether it works at all, so may be
> do that in two stages - commit the generalization of win32, then get the
> aix changes as a patch and get someone to test it before committing it.
> Otherwise we may break, otherwise working things.

Thanks, Stas - I'll swap the order of those constants and
also take out the AIX stuff and commit.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message