perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fred Moyer" <f...@taperfriendlymusic.org>
Subject [mp2] Report on mp2 accessors in apache_structures.map
Date Tue, 10 Aug 2004 15:20:46 GMT
Per Stas Bekman's request I have reviewed the accessor settings in
modperl-2.0/xs/maps/apache_structures.map against the doc pages for
entries that should be read/write and generated a diff [1] against the
current cvs.

I have found methods in the man pages which are not in structures.map, and
some methods which look like they should be read only, but no methods so
far which should be changed to read/write.  Most of this diff is for
methods that are currently read/write and look like they should be read
only.

Make test has returned 'All tests successful' with this modified file
apache_structures.map.  Should this patch be acceptable please let me know
if I should add additional methods that are doumented but not in the map
file.

Thanks,

Fred

[1]

--- apache_structures.map	8 Aug 2004 18:04:55 -0000	1.36
+++ apache_structures.map	10 Aug 2004 13:57:25 -0000
@@ -28,7 +28,7 @@
    allowed_xmethods
    allowed_methods
 >  sent_bodyct
-   bytes_sent
+<  bytes_sent
    mtime
 >  chunked
 >  range
@@ -51,7 +51,7 @@
    user
    ap_auth_type
 ~  no_cache
-   no_local_copy
+<  no_local_copy
 <  unparsed_uri
    uri
    filename
@@ -100,26 +100,26 @@
 </server_rec>

 <conn_rec>
-   pool
-   base_server
+<  pool
+<  base_server
 >  vhost_lookup_data
-   local_addr
-   remote_addr
-   remote_ip
-   remote_host
+<  local_addr
+<  remote_addr
+<  remote_ip
+<  remote_host
    remote_logname
-   aborted
+<  aborted
    keepalive
 ?  double_reverse
    keepalives
-   local_ip
-   local_host
-   id
+<  local_ip
+<  local_host
+<  id
    conn_config
    notes
    input_filters
    output_filters
-   sbh
+<  sbh
    bucket_alloc
 </conn_rec>

@@ -131,11 +131,17 @@
 </server_addr_rec>

 <module>
-   version
-   minor_version
-   module_index
-   name
-   dynamic_load_handle
+<  version
+<  find_linked_module
+<  find_module_name
+   remove_loaded_module
+   remove_module
+<  top_module
+<  version
+<  minor_version
+<  module_index
+<  name
+>  dynamic_load_handle
    next
 >  magic
 -  rewrite_args
@@ -143,7 +149,7 @@
 >  merge_dir_config
 >  create_server_config
 >  merge_server_config
-   cmds
+<  cmds
 >  register_hooks
 </module>

@@ -156,6 +162,9 @@
 </process_rec>

 <command_rec>
+<  chk_cmd_context
+<  soak_end_container
+<  next
    name
    func
    cmd_data
@@ -185,14 +194,18 @@
 </ap_method_list_t>

 <ap_directive_t>
-   directive
+<  as_hash
+<  as_string
+<  lookup
+   walk_config
+<  directive
    args
-   next
-   first_child
-   parent
+<  next
+<  first_child
+<  parent
    data
-   filename
-   line_num
+<  filename
+<  line_num
 </ap_directive_t>

 !<ap_configfile_t>







---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message