perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: cvs commit: modperl-2.0/xs/tables/current/Apache ConstantsTable.pm
Date Fri, 13 Aug 2004 00:12:34 GMT


Stas Bekman wrote:
> Geoffrey Young wrote:
> 
>>>Have you by chance noticed:
>>>
>>>% cat xs/tables/current/Apache/ConstantsTable.pm
>>>package Apache::ConstantsTable;
>>>
>>># !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>>># ! WARNING: generated by Apache::ParseSource/0.02
>>># !          Mon May  3 13:30:11 2004
>>># !          do NOT edit, any changes will be lost !
>>># !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>>>
>>>The next time the source scan will be run, your changes will be lost.
>>
>>
>>in all fairness, we've hand-edited that file tons of times, so it's not
>>really like there is no precident for it (and I'm the one who told him to
>>just add them :)
> 
> 
> Luckily, that is not the case for a few months already. And it saved me 
> a lot of time, since I started working on the API polish.
> 
> 
>>I guess that along with the edit is adding the 'context' group to
>>Apache::ParseSource so that the table is correctly generated next time
>>somebody runs it.
> 
> 
> No, not really. 'make source_scan' will do the edit for you. That's the 
> whole point of it. The only reason we were doing it manually is because 
> it was broken. It works now. So one needs to tweaks ParseSource to pick 
> up that group.

Thanks for pointing it out, I've checked in a revised version of SourceScan.pm

> 
>>sorry.
> 
> 
> No problem :)
> 
> 

-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message