perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: Compat implementations of method_register and server_root_relative in tests ?
Date Mon, 09 Aug 2004 21:16:57 GMT


Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> 
> 
>>         ok t_filepath_cmp(canonpath(Apache->server_root_relative),
>>                           canonpath($server_root),
>>                           'Apache->server_root_relative()');
>>+
>>+        ok t_filepath_cmp(canonpath(Apache->server_root_relative('/tmp')),
>>+                          canonpath('/tmp'),
>>+                          "Apache->server_root_relative('/tmp')");
>>     }
> 
> 
> I think it's more like:
> 
>     $path = catdir Apache::ServerUtil::server_root, "logs";
>     ok t_filepath_cmp(canonpath(Apache->server_root_relative($path)),
>                           canonpath($path),
>                           "Apache->server_root_relative($path)");
> 
> since usually it's:
> 
>    $r->server_root_relative($component), where $component is either 
> relative to serverroot or already a full path (whose base is serverroot)

Yes, see attached patch.

As it turns out File::Spec->file_name_is_absolute(undef) is apparently not
absolute, so testing for defined'ess is redundant, but I'd leave it in anways,
as it makes the goal of the code clearer.

-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message