perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: Compat implementations of method_register and server_root_relative in tests ?
Date Mon, 09 Aug 2004 21:05:45 GMT

>> So back to the compat issue. At the moment lib/Apache/compat.pm has:
>>
>> sub server_root_relative {
>>      my $class = shift;
>>      File::Spec->catfile(Apache::ServerUtil::server_root, @_);
>> }
>>
>> which doesn't cover that special case. I suppose before doing catfile 
>> we need to check whether $_[0] is already absolute, in which case we 
>> should not concat server_root in.
> 
> 
> So would this patch resolve this open issue ?

it's a good starting point, but it's incomplete.

> Index: lib/Apache/compat.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
> retrieving revision 1.114
> diff -u -I$Id -r1.114 compat.pm
> --- lib/Apache/compat.pm	24 Jul 2004 07:27:03 -0000	1.114
> +++ lib/Apache/compat.pm	9 Aug 2004 20:57:22 -0000
> @@ -249,8 +249,13 @@
>  package Apache;
>  
>  sub server_root_relative {
> -    my $class = shift;
> -    File::Spec->catfile(Apache::ServerUtil::server_root, @_);
> +    my ($class, $path, @extra) = @_;
> +    if (File::Spec->file_name_is_absolute($path)) {

$path could be undef. Many times people call just 
Apache->server_root_relative().

> +        return File::Spec->catfile($path, @extra); 
> +    }
> +    else {
> +        File::Spec->catfile(Apache::ServerUtil::server_root, $path, @extra);
> +    }
>  }

and tests :)

Geoff, was it the only thing about server_root_relative specifics, or 
was there something else?

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message