perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: modperl-2.0/todo release
Date Sat, 07 Aug 2004 21:15:26 GMT
Philippe M. Chiasson wrote:
[...]
>> If the macro is supposed to suggest the allowed context and PerlModule 
>> is not allowed in DIR, then DIR is not appropriate. I see no problem 
>> with long names if they require no extra source code reading to figure 
>> out what they really do. These are internal macros and there are used 
>> in one place, so what's the big deal with choosing a clear name, even 
>> if it's long?
> 
> 
> Well, there are 2 macros that must work together, so one possibility 
> would be so call
> 
>  MP_CMD_ANYWHERE_RAW_ARGS("Perl", perldo, "Perl Code"),
> 
> And clearly at the top of the perldo implementation:
>  MP_CMD_SRV_DECLARE(requires)
>  {
>      MP_dSCFG(parms->server);
>      MP_PERL_DECLARE_CONTEXT;
>      MP_CMD_SERVER_OR_HTACCESS_ONLY;
> 
> Would something like that be somewhat clearer ?

We have the following contexts:

DIR
SRV
HTACCESS

each directive can be either:

DIR
SRV
SRV + HTACCESS
DIR + HTACCESS

correct? So why not base the naming based on that?

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message