perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: modperl-2.0/todo release
Date Sat, 07 Aug 2004 03:07:38 GMT
gozer@apache.org wrote:
> gozer       2004/08/06 19:52:08

>    static const command_rec modperl_cmds[] = {  
>        MP_CMD_SRV_ITERATE("PerlSwitches", switches, "Perl Switches"),
>   -    MP_CMD_SRV_ITERATE("PerlModule", modules, "PerlModule"),
>   -    MP_CMD_SRV_ITERATE("PerlRequire", requires, "PerlRequire"),
>   +    MP_CMD_DIR_ITERATE("PerlModule", modules, "PerlModule"),
>   +    MP_CMD_DIR_ITERATE("PerlRequire", requires, "PerlRequire"),
>        MP_CMD_DIR_ITERATE("PerlOptions", options, "Perl Options"),
>        MP_CMD_DIR_ITERATE("PerlInitHandler", init_handlers, "Subroutine name"),
>        MP_CMD_DIR_TAKE2("PerlSetVar", set_var, "PerlSetVar"),
>        MP_CMD_DIR_ITERATE2("PerlAddVar", add_var, "PerlAddVar"),
>        MP_CMD_DIR_TAKE2("PerlSetEnv", set_env, "PerlSetEnv"),
>        MP_CMD_SRV_TAKE1("PerlPassEnv", pass_env, "PerlPassEnv"),
>   -    MP_CMD_SRV_RAW_ARGS_ON_READ("<Perl", perl, "Perl Code"),
>   -    MP_CMD_SRV_RAW_ARGS("Perl", perldo, "Perl Code"),
>   +    MP_CMD_DIR_RAW_ARGS_ON_READ("<Perl", perl, "Perl Code"),
>   +    MP_CMD_DIR_RAW_ARGS("Perl", perldo, "Perl Code"),

As mentioned here several times, this naming is confusing. It's 
misleading, since it suggests DIR when it is not the case. Why not call 
the macros differently? s/DIR/SRV_N_HTACCESS/ or whatever other name you 
prefer?

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message