perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: Trying to test current apreq2 CVS
Date Sun, 04 Jul 2004 19:02:54 GMT
On Sun, 4 Jul 2004, Stas Bekman wrote:

> Randy Kobes wrote:
> > [ trimmed apreq-dev from cc list ]
> > On Sun, 4 Jul 2004, Markus Wichitill wrote:
> >
> >
> >>>>C:\A\modperl-2.0\blib\arch\Apache2\auto\aprext\aprext.lib : fatal error
> >>>>LNK1136: invalid or corrupt file
> >>>
> >>>Is this with the current mp2 cvs?
> >>
> >>Yes.
> >>
> >>
> >>>- was aprext.lib built (shortly after building mod_perl.so)?
> >>>- if so, was it put under
> >>>     C:\A\modperl-2.0\blib\arch\Apache2\auto\aprext\
> >>>  If not, can you find where?
> >>
> >>It's built and put under blib\arch\auto\aprext.
> >>
> >>I don't use MP_INST_APACHE2 BTW.
> >
> >
> > Sorry about that - in the cvs I was assuming MP_INST_APACHE2
> > was being used. Could you try the following patch against
> > the mod_perl 2 cvs? I'll also send it to you (privately) as
> > an attachment, in case you have trouble applying it. Thanks.
>
> +1

Thanks, Stas - I just committed this, with the changes noted
below.

> >  aprext:
> > -        cd "$aprext" && \$(MAKE) -f \$(FIRST_MAKEFILE) all \$(PASTHRU)
> > +        cd "$src_dir" && \$(MAKE) -f \$(FIRST_MAKEFILE) all \$(PASTHRU)
>
> BTW, since it's a normal Makefile (not Makefile.foo), why do you need the -f
> ... part? I suppose a copy-n-paste from the src/modules/perl target :)

:) You're right, it's not needed - I removed the -f.

> > Index: lib/ModPerl/BuildOptions.pm
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/lib/ModPerl/BuildOptions.pm,v
> > retrieving revision 1.26
> > diff -u -r1.26 BuildOptions.pm
> > --- lib/ModPerl/BuildOptions.pm	4 Mar 2004 06:01:06 -0000	1.26
> > +++ lib/ModPerl/BuildOptions.pm	4 Jul 2004 16:03:05 -0000
> > @@ -226,4 +226,4 @@
> >  GENERATE_XS    0    Generate XS code based on httpd version
> >  LIBNAME        0    Name of the modperl dso library (default is  mod_perl)
> >  COMPAT_1X      0    Compile-time mod_perl 1.0 backcompat (default is  on)
> > -
> > +APR_LIB        0    Lib used to build APR::* on Win32 (default is aprext)
>
> this should go to docs too :)

I'll do that ... Also, in the original, I had MP_APR_LIB
defined to a default of 'aprext' only on Win32 (as it's
presently not used anywhere else). However, in testing it on
unix, Makefile.PL in xs/APR/aprext/ emits a warning about
guessing the name (because MP_APR_LIB is used there to set
the NAME MakeMaker attribute). So I changed things so
MP_APR_LIB has the 'aprext' default on all platforms.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message