perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp2] modperl_config_insert_request's path argument
Date Tue, 06 Jul 2004 07:36:15 GMT
Philippe M. Chiasson wrote:
> Stas Bekman wrote:
> 
>> Philippe, I've noticed this comment http_config.h:
>>
>> struct cmd_parms_struct {
>> [...]
>>     /** If configuring for a directory, pathname of that directory.
>>      *  NOPE!  That's what it meant previous to the existance of <Files>,
>>      * <Location> and regex matching.  Now the only usefulness that 
>> can be
>>      * derived from this field is whether a command is being called in a
>>      * server context (path == NULL) or being called in a dir context
>>      * (path != NULL).  */
>>     char *path;
>>
>> Which I think makes the optional 2nd arg 'path' to s->add_config 
>> redundant. Moreover the default (r->filename) might be incorrect if 
>> it's NULL. So should we drop it completely in here:
>>
>> const char *modperl_config_insert_request(pTHX_
>>                                           request_rec *r,
>>                                           SV *lines,
>>                                           char *path,
>>                                           int override)
>> {
>>     const char *errmsg;
>>     ap_conf_vector_t *dconf = ap_create_per_dir_config(r->pool);
>>
>>     errmsg = modperl_config_insert(aTHX_
>>                                    r->server, r->pool, r->pool,
>>                                    override, path,
>>                                    dconf, lines);
>>
>> replacing it with '/' or something? Or am I misreading it?
> 
> 
> I've looked at it just now, and I think you are correct. I can't seem to 
> find a reason why we should be doing this. And you are also
> correcet in saying that a directive for a null r->filename might be 
> treated as a server configuration accidentally.
> 
>> We don't have any tests for this and I haven't looked at config stuff 
>> for ages, so I'm not sure whether we should keep it or drop it.
> 
> 
>> What do you think?
> 
> 
> 
> I think it's a good idea to get rid of it somehow like this :

+1!


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message