perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@cpan.org>
Subject [Patch mp2] Was : mp2 acl support?
Date Mon, 09 Feb 2004 22:35:02 GMT
On Sun, 2004-02-08 at 04:03 -0500, Andres Salomon wrote:
> Hi Stas,
> 
> I was wondering about the status of ACL support for modperl2.  The
> following two urls contain info and patches:
> 
> http://www.gossamer-threads.com/archive/mod_perl_C1/modperl_F7/%5BPATCH%5D_acl_support_P58252/
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=230439
> 
> However, I haven't seen any patches that have been verified to work w/ ACL
> setups, and don't break w/ non-ACL setups.  Have you gotten any success
> reports on your patch?
> 

Could someone running the ModPerl-Registry tests on Win32 or something
similarly non-POSIX with this ACL patch ?

Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm,v
retrieving revision 1.41
diff -u -I$Id -r1.41 RegistryCooker.pm
--- ModPerl-Registry/lib/ModPerl/RegistryCooker.pm	25 Jan 2004 01:04:16 -0000	1.41
+++ ModPerl-Registry/lib/ModPerl/RegistryCooker.pm	9 Feb 2004 22:32:11 -0000
@@ -232,11 +232,16 @@
     return Apache::DECLINED if -d _;
 
     $self->{MTIME} = -M _;
-
-    unless (-x _ or IS_WIN32) {
-        $r->log_error("file permissions deny server execution",
-                       $self->{FILENAME});
-        return Apache::FORBIDDEN;
+    
+    {
+        #Allow correct detection even under ACLs
+        use filetest qw(access);
+    
+        unless (-x _ or IS_WIN32) {
+            $r->log_error("file permissions deny server execution",
+                           $self->{FILENAME});
+            return Apache::FORBIDDEN;
+        }
     }
 
     if (!($r->allow_options & Apache::OPT_EXECCGI)) {


> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Mime
View raw message