Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 63932 invoked from network); 11 Dec 2003 13:46:58 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 11 Dec 2003 13:46:58 -0000 Received: (qmail 30368 invoked by uid 500); 11 Dec 2003 13:46:55 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 30353 invoked by uid 500); 11 Dec 2003 13:46:54 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 30339 invoked from network); 11 Dec 2003 13:46:54 -0000 Received: from unknown (HELO secure.exclamationlabs.net) (66.77.29.186) by daedalus.apache.org with SMTP; 11 Dec 2003 13:46:54 -0000 Received: from modperlcookbook.org (pcp05675728pcs.walngs01.pa.comcast.net [69.139.161.218]) (authenticated (0 bits)) by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id hBBDkhU08986; Thu, 11 Dec 2003 07:46:43 -0600 Message-ID: <3FD87541.30605@modperlcookbook.org> Date: Thu, 11 Dec 2003 08:46:41 -0500 From: Geoffrey Young User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Stas Bekman CC: mod_perl Dev Subject: Re: [mp2 filters] allocating modperl_wbucket_t or not References: <3FD839C1.2050106@stason.org> In-Reply-To: <3FD839C1.2050106@stason.org> X-Enigmail-Version: 0.71.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Stas Bekman wrote: > Currently we allocate a wbucket of type modperl_wbucket_t for each > filter invocation. If it's not a streaming filter (i.e. manipulates > bucket brigades or doesn't use read/print) it's never going to need > wbucket. wbucket consumes 16404 bytes, the filter struct without > wbucket consumes 60 bytes. In order not to penalize non-streaming > filters, I suggest not to allocate wbucket if and not until it's first > used. you're still way ahead of the game here, so go with what you think is best (thanks for asking, though :) if you have the time and can explain what a wbucket is, that would be great, too :) --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org