perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: [mp2] ModPerl-Registry redirect test
Date Thu, 04 Dec 2003 07:19:42 GMT
On Wed, 3 Dec 2003, Stas Bekman wrote:

> Randy Kobes wrote:
> [...]
> > I think if one wants to grow old fast, offer to help
> > maintain File::Spec :)
>
> There is a better candidate, ExtUtils::MakeMaker. I wonder
> how old was Michael 2 years ago. ;)

:)

[ .. ]
> So if you have:
> C:\\MODPERL~1 => C:\\mod_perl-foo-1
> D:\\MODPERL~1 => D:\\mod_perl-bar-1
>
> and pass MODPERL~1 to Win32::GetLongPathName() without the drive, it will
> expand it as if C:\\mod_perl-foo-1 (if cwd is somewhere in C:\\) even if
> D:\\mod_perl-bar-1 was intended. I guess that's expected, and you better not
> forget to pass that drive letter... ;)

Drive letters are such stupid things ...

> +1 plus probably add an inlined comment for both explaining why there are
> needed, and the pod sections. i'd also add a comment that GetLongPathName
> requires an absolute path to work.
>
> > -my $script_file = catfile $vars->{serverroot}, 'cgi-bin', 'basic.pl';
> > +my $script_file = t_catfile_apache($vars->{serverroot}, 'cgi-bin', 'basic.pl');
>
> no need for () as it's imported.
>
> > -    my $script_file = catfile $vars->{serverroot}, 'cgi-bin', 'basic.pl';
> > +    my $script_file = t_catfile_apache($vars->{serverroot}, 'cgi-bin', 'basic.pl');
>
> ditto

I just committed that - thanks, Stas!

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message