perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rafael Garcia-Suarez <raphel.garcia-sua...@hexaflux.com>
Subject Re: [mp2] failing getppid test with 5.8.0
Date Fri, 07 Nov 2003 08:48:21 GMT
Stas Bekman wrote:
>
> Scott gets the getppid test failing with mp2-cvs/5.8.0 but I can't reproduce 
> it. I think this is because RH ships a fake 5.8.0. It says MAINT18379 which 
> dates 27 Dec 2002 (5 months after 5.8.0 was released)
> http://public.activestate.com/cgi-bin/perlbrowse?patch=18379
> This problem shouldn't have happened since ppid caching was introduced in 5.8.1.

At some point we can't support all broken perls vendors ship.

> Scott, this patch will most likely make the error go away. Please confirm that 
> it does.

However THREADS_HAVE_PIDS doesn't exist in 5.8.0 so the patch below is safe
to be applied, I believe. (although PERL_SUBVERSION >= 0 is always true, so the #if
can be further simplified to #if PERL_VERSION >= 8)

> Index: src/modules/perl/modperl_perl.h
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_perl.h,v
> retrieving revision 1.12
> diff -u -r1.12 modperl_perl.h
> --- src/modules/perl/modperl_perl.h     3 Nov 2003 23:31:19 -0000       1.12
> +++ src/modules/perl/modperl_perl.h     6 Nov 2003 23:39:47 -0000
> @@ -2,7 +2,7 @@
>   #define MODPERL_PERL_H
> 
>   #if PERL_REVISION == 5 && \
> -    (PERL_VERSION == 8 && PERL_SUBVERSION >= 1 || PERL_VERSION >= 9) &&
\
> +    (PERL_VERSION == 8 && PERL_SUBVERSION >= 0 || PERL_VERSION >= 9) &&
\
>       THREADS_HAVE_PIDS
>   #define MP_MAINTAIN_PPID
>   #endif

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message