Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 1 Oct 2003 13:23:42 -0500 (CDT)
From: Randy Kobes <randy@theoryx5.uwinnipeg.ca>
To: Stas Bekman <stas@stason.org>
cc: Barrie Slaymaker <barries@slaysys.com>,
 Steve Hay <steve.hay@uk.radan.com>,
   mod_perl Dev <dev@perl.apache.org>
Subject: Re: t/SMOKE on win32
In-Reply-To: <3F7B1873.5060508@stason.org>
Message-ID: <Pine.LNX.4.56.0310011317030.30272@theoryx5.uwinnipeg.ca>
References: <200309301950.h8UJoV125267@ironsides.slaysys.com>
 <3F79F1B4.2070804@stason.org>
 <Pine.LNX.4.56.0309302359080.22525@theoryx5.uwinnipeg.ca>
 <3F7B1873.5060508@stason.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Wed, 1 Oct 2003, Stas Bekman wrote:

> Randy Kobes wrote:
[ ... ]
> > And that does seem to work! A diff appears below (not tested
> > on linux) - in this, I also added a change to TestServer.pm
> > to print out a message on Win32 when shutting down the
> > server, as that's expected when checking that the server
> > successfully shut down in TestSmoke.pm.
>
> Great, Randy, +1 to commit, but please drop
>
> > +        print $log;
>
> in 3 places. If you want a verbose output run with -verbose.

I haven't tested this on unix, but without the
   print $log;
statements what would happen is that there would be no
output to the terminal screen at all until the smoking was
completed. I thought it was nice to see at least the
progress - which test was currently running, etc. And isn't
"verbose" different, in that it will include the results of
running the subtests within each test?

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org