Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 23666 invoked from network); 2 Oct 2003 08:23:08 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 2 Oct 2003 08:23:08 -0000 Received: (qmail 70652 invoked by uid 500); 2 Oct 2003 08:22:43 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 70636 invoked by uid 500); 2 Oct 2003 08:22:42 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 70600 invoked from network); 2 Oct 2003 08:22:42 -0000 Received: from unknown (HELO mail.logilune.com) (195.154.174.52) by daedalus.apache.org with SMTP; 2 Oct 2003 08:22:42 -0000 Received: from stason.org (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id 80D4C79B44; Thu, 2 Oct 2003 10:22:53 +0200 (CEST) Message-ID: <3F7BE05B.9030401@stason.org> Date: Thu, 02 Oct 2003 01:22:51 -0700 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 Cc: ydnar , dev@perl.apache.org Subject: Re: [mp2] useless warning on ModPerl::Util::exit() References: <086101c38876$870ed300$8a01a8c0@PHS> <3F7B69C4.5040303@stason.org> <086e01c3887c$69aca430$8a01a8c0@PHS> <3F7B7387.80304@stason.org> In-Reply-To: <3F7B7387.80304@stason.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Stas Bekman wrote: >> It does not occur when running the t/TEST script. I was not able to >> modify >> t/response/TestModperl/exit.pm to reproduce either. Hence the example >> handler as you requested. > > > Perfect, I'm now able to reproduce your problem. Please stay tuned for > the fix. I haven't figured out why the test doesn't have the same problem, but please try the following patch: Index: src/modules/perl/modperl_callback.c =================================================================== RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_callback.c,v retrieving revision 1.59 diff -u -r1.59 modperl_callback.c --- src/modules/perl/modperl_callback.c 23 Sep 2003 20:12:11 -0000 1.59 +++ src/modules/perl/modperl_callback.c 2 Oct 2003 08:20:52 -0000 @@ -74,7 +74,14 @@ status = OK; } else { - status = POPi; + I32 ax = (SP - PL_stack_base) + 1 ; + if (SvIOK(ST(0))) { + status = POPi; + } + else { + /* ModPerl::Util::exit doesn't return an integer value */ + status = OK; + } /* assume OK for non-http status codes and for 200 (HTTP_OK) */ if (((status > 0) && (status < 100)) || (status == 200) || (status > 600)) { __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org