perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: t/SMOKE on win32
Date Fri, 03 Oct 2003 05:56:13 GMT
On Fri, 3 Oct 2003, Randy Kobes wrote:

> I've tried testing this, and haven't come across a problem
> yet, but this wasn't very extensive, as it's late ...
> (Stas, I've kept in the "print $log" statements just
> for debugging purposes).

I forgot - similar to an earlier fix for modperl_io.c,
I included the following:
==========================================================
Index: src/modules/perl/modperl_io.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_io.c,v
retrieving revision 1.13
diff -u -r1.13 modperl_io.c
--- src/modules/perl/modperl_io.c	2 Oct 2003 23:01:56 -0000	1.13
+++ src/modules/perl/modperl_io.c	3 Oct 2003 05:42:25 -0000
@@ -109,7 +109,7 @@
      * have file descriptors, so STDOUT must be closed before it can
      * be reopened */
     Perl_do_close(aTHX_ handle, TRUE);
-    status = Perl_do_open9(aTHX_ handle, "<:Apache", 8, FALSE, O_RDONLY,
+    status = Perl_do_open9(aTHX_ handle, "<:Apache", 7, FALSE, O_RDONLY,
                            0, Nullfp, sv, 1);
     if (status == 0) {
         Perl_croak(aTHX_ "Failed to open STDIN: %_", get_sv("!", TRUE));

=========================================================================

Also, in case you don't have it from before, here's a patch
for Apache::TestServer to give a Win32 error message upon
shutdown:

=====================================================================
Index: Apache-Test/lib/Apache/TestServer.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestServer.pm,v
retrieving revision 1.66
diff -u -r1.66 TestServer.pm
--- Apache-Test/lib/Apache/TestServer.pm	1 Oct 2003 13:45:23 -0000	1.66
+++ Apache-Test/lib/Apache/TestServer.pm	3 Oct 2003 05:42:58 -0000
@@ -316,12 +316,14 @@
     if (Apache::TestConfig::WIN32) {
         if ($self->{config}->{win32obj}) {
             $self->{config}->{win32obj}->Kill(0);
+            warning "server $self->{name} shutdown";
             return 1;
         }
         else {
             require Win32::Process;
             my $pid = $self->pid;
             Win32::Process::KillProcess($pid, 0);
+            warning "server $self->{name} shutdown";
             return 1;
 	}
     }

===================================================================

Also, I just tried a long run (with the above change to
modperl_io.c), and now I do get a (seemingly) random
failure, but the error message is
   Failed to dup STDOUT: Permission denied
and not STDIN. Not sure if this is progress ...

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message