perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp2] useless warning on ModPerl::Util::exit()
Date Thu, 02 Oct 2003 08:22:51 GMT
Stas Bekman wrote:

>> It does not occur when running the t/TEST script. I was not able to 
>> modify
>> t/response/TestModperl/exit.pm to reproduce either. Hence the example
>> handler as you requested.
> 
> 
> Perfect, I'm now able to reproduce your problem. Please stay tuned for 
> the fix.

I haven't figured out why the test doesn't have the same problem, but please 
try the following patch:

Index: src/modules/perl/modperl_callback.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_callback.c,v
retrieving revision 1.59
diff -u -r1.59 modperl_callback.c
--- src/modules/perl/modperl_callback.c 23 Sep 2003 20:12:11 -0000      1.59
+++ src/modules/perl/modperl_callback.c 2 Oct 2003 08:20:52 -0000
@@ -74,7 +74,14 @@
              status = OK;
          }
          else {
-            status = POPi;
+            I32 ax = (SP - PL_stack_base) + 1 ;
+            if (SvIOK(ST(0))) {
+                status = POPi;
+            }
+            else {
+                /* ModPerl::Util::exit doesn't return an integer value */
+                status = OK;
+            }
              /* assume OK for non-http status codes and for 200 (HTTP_OK) */
              if (((status > 0) && (status < 100)) ||
                  (status == 200) || (status > 600)) {


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message