perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: cvs commit: modperl-2.0/t/hooks/TestHooks authen.pm authz.pm
Date Thu, 19 Jun 2003 11:18:04 GMT


Stas Bekman wrote:
> Geoffrey Young wrote:
> 
>>
>>>   -use Apache::Const -compile => qw(OK AUTH_REQUIRED SERVER_ERROR);
>>>   +use Apache::Const -compile => qw(OK HTTP_UNAUTHORIZED SERVER_ERROR);
>>
>>
>>
>> if you want to go this route, you might as well use 
>> HTTP_INTERNAL_SERVER_ERROR as well :)
> 
> 
> I thought you had a commit access? ;)

ah, but you missed the point :)

the real question is this, do we want to advocate HTTP_ constants or the 
older, more common (and perfectly valid since they do exist) ones?

I'm of the opinion that we should be consistent - if we're going to switch 
to HTTP_UNAUTHORIZED then it should be HTTP_INTERNAL_SERVER_ERROR, 
HTTP_MOVED_TEMPORARILY, and so on, both here and across the board in all the 
tests and docs.  just changing one instance simply adds confusion.

so, I will go ahead and uniformly change the constants throughout the tests 
(well, I'll add it to my ToDo list, anyway :) if we can all agree the 
uniform approach is best.  otherwise, I suggest reverting this patch and 
just letting everything proceed the way most people are used to.

--Geoff




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message