perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp1] failed modules/module
Date Thu, 05 Jun 2003 01:42:17 GMT
Philippe M. Chiasson wrote:
> On Wed, 2003-06-04 at 13:38, Stas Bekman wrote:
> 
>>blead-perl w/o ithreads fails modules/module.t with this error:
>>
>>[Wed Jun  4 15:34:41 2003] [error] Can't locate 
>>auto/Apache/Module/top_module.al in @INC (@INC contains: 
>>/home/stas/apache.org/modperl/blib/lib /home/stas/apache.org/modperl/blib/arch 
>>/home/stas/apache.org/modperl/t/docs 
>>/home/stas/perl/blead/lib/5.9.0/i686-linux /home/stas/perl/blead/lib/5.9.0 
>>/home/stas/perl/blead/lib/site_perl/5.9.0/i686-linux 
>>/home/stas/perl/blead/lib/site_perl/5.9.0 /home/stas/perl/blead/lib/site_perl 
>>/home/stas/apache.org/modperl/t/ /home/stas/apache.org/modperl/t/lib/perl) at 
>>/home/stas/apache.org/modperl/t/net/perl/module.pl line 20
> 
> 
> Can't reproduce that one ;-(
> 
> Your test are possibly grabbign an version of Apache::Module compiled
> with a previous (incompatible MMN) or something
> 
> $> perl -MApache::Module -e'print $INC{"Apache/Module.pm"}'
> 
> I just dumped Apache-Module-0.11 in my mod_perl build directory and it
> got picked up and all tests passed fine, with this simple (yet odd)
> patch:

oh, you mean you were running 'make test' and having all those skipped and you 
considered them as passed? that sounds like a bad idea.

> diff -u -I$Id -r1.28 src.pm
> --- lib/Apache/src.pm   9 Jul 2001 15:03:13 -0000       1.28
> +++ lib/Apache/src.pm   4 Jun 2003 07:16:47 -0000
> @@ -94,7 +94,7 @@
>  #    return 1 if $Is_Win32; #just assume, till Apache::src works under
> win32
>      my $instsrc;
>      {
> -       local @INC = grep { !/blib/ } @INC;
> +       #local @INC = grep { !/blib/ } @INC;
>         my $instdir;
>          for (@INC) {
>              last if -d ($instdir = "$_/auto/Apache/include");
> 
> 
> Can you check for something like that, otherwise I can't reproduce that
> problem with your setup.

With your t/TEST patch below and reinstalled Apache::Module it seems to go away.

>>also here we advise to use t/TEST but its shebang line could be wrong (if 
>>/usr/local/bin/perl wasn't used).
>>http://perl.apache.org/docs/1.0/guide/install.html#Manual_Testing
>>Would be nice to adjust t/TEST to use the right perl path
> 
> 
> Like this? 

+1, we want it in!

> Index: MANIFEST
> ===================================================================
> RCS file: /home/cvs/modperl/MANIFEST,v
> retrieving revision 1.71
> diff -u -I$Id -r1.71 MANIFEST
> --- MANIFEST    25 May 2003 10:54:06 -0000      1.71
> +++ MANIFEST    4 Jun 2003 07:21:25 -0000
> @@ -98,7 +98,7 @@
>  src/opcodes.txt
>  t/report.PL
>  t/README
> -t/TEST
> +t/TEST.PL
>  t/TEST.win32
>  t/conf/httpd.conf.pl
>  t/conf/httpd.conf-dist
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvs/modperl/Makefile.PL,v
> retrieving revision 1.211
> diff -u -I$Id -r1.211 Makefile.PL
> --- Makefile.PL 16 May 2003 13:26:38 -0000      1.211
> +++ Makefile.PL 4 Jun 2003 07:21:26 -0000
> @@ -148,6 +148,7 @@
>     src/modules/perl/mod_perl_version.h
>     t/net/perl/cgi.pl
>     t/report
> +   t/TEST
>     t/httpd
>     apaci/find_source
>     apaci/apxs_cflags
> @@ -166,6 +167,7 @@
> 
>  gen_script("t/net/perl/cgi.pl");
>  gen_script("t/report");
> +gen_script("t/TEST");
>  gen_script("apaci/find_source");
>  gen_script("apaci/apxs_cflags");
>  gen_script("apaci/perl_config", "$PWD/lib");
> Index: t/.cvsignore
> ===================================================================
> RCS file: /home/cvs/modperl/t/.cvsignore,v
> retrieving revision 1.3
> diff -u -I$Id -r1.3 .cvsignore
> --- t/.cvsignore        9 Jun 1998 16:53:09 -0000       1.3
> +++ t/.cvsignore        4 Jun 2003 07:21:26 -0000
> @@ -1,4 +1,5 @@
>  report
> +TEST
>  logs
>  httpd.conf
>  httpd.conf.old
> 
> And rename t/TEST to t/TEST.PL
> 
> Works fine for me and is nicely autogenerated. +1 ?

+1, absolutely!

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message