perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@cpan.org>
Subject Re: [mp2 Patch] Simple changes to current Apache::Reload for mp1 & mp2
Date Thu, 19 Jun 2003 04:44:31 GMT
On Thu, 2003-06-19 at 12:22, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > I needed this simple patch to get Apache::Reload working in mp1.
> > 
> > Any objections to at least applying this so it is ready for possible
> > inclusion in mp1's upcoming release?
> > 
> > Of course, if Steve Hay's suggestions make it through, keeping the
> > backwards compatibility would become important as well.
> > 
> > Gozer out.
> 
> you obviously haven't tested it with perl 5.005. what about the 'warnings' pragma?

Oupss, my bad ;-( But that's quite trivially fixable, isn't it?

> I think Apache::Reload is simple enough to have two copies of it, adjusted for 
> each mod_perl generation.

It's also quite simple enough to have one copy handle mp1 and mp2 with
only a few lines of code. Or is that a "bad thing" ?

> If we "hijack" Matt's distro and keep it as a separate module on CPAN, only 
> syncing modperl and modperl-2.0 trees, then it's a whole different story. but 
> again we hit this problem with PAUSE still not quite supporting bundling :(
> (i.e. we don't want CPAN.pm to try to install mod_perl, when someone is trying 
> to install Apache::Reload)

That's indeed a problem with CPAN ;-( Then why not simply make sure
Apache::Reload works with both mod_perl generations and maintain it on
CPAN? As long as there is only one version of it and that it works with
mp1 and mp2, I don't see what the problem could be.

perl -MCPAN -e 'install Apache::Reload'

Another problem I can see is someone having a dual setup with both mp1
and mp2. Shoulb be able to install Apache::Reload once in site_perl, not
twice in mp specific PREFIXes ...

> Proposal: keep the two separate for now, just make sure that the versions are 
> different. For example 1.00 for mp1 and 2.00 for mp2. For the next release(s) 
> hopefully PAUSE will support bundles and then we can decide how to act.

Proposal: Just take Apache::Reload off mp2 and released on CPAN.

> > Index: lib/Apache/Reload.pm
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/lib/Apache/Reload.pm,v
> > retrieving revision 1.11
> > diff -u -I$Id -r1.11 Reload.pm
> > --- lib/Apache/Reload.pm	3 Jun 2003 00:09:04 -0000	1.11
> > +++ lib/Apache/Reload.pm	18 Jun 2003 05:16:07 -0000
> > @@ -3,15 +3,23 @@
> >  use strict;
> >  use warnings FATAL => 'all';
> >  
> > -use mod_perl 1.99;
> > +use mod_perl;
> >  
> > -our $VERSION = '0.09';
> > +use constant MOD_PERL2 => $mod_perl::VERSION >= 1.99;
> >  
> > -use Apache::Const -compile => qw(OK);
> > +our $VERSION = '0.09';
> >  
> > -use Apache::Connection;
> > -use Apache::ServerUtil;
> > -use Apache::RequestUtil;
> > +if (MOD_PERL2) {
> > +    require Apache::Const;
> > +    Apache::Const->import(qw(OK));
> > +    require Apache::Connection;
> > +    require Apache::ServerUtil;
> > +    require Apache::RequestUtil;
> > +}
> > +else {
> > +    require Apache::Constants;
> > +    Apache::Constants->import(qw(OK));
> > +}
> >  
> >  use vars qw(%INCS %Stat $TouchTime %UndefFields);
> >  
> > 
> > 
-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'


Mime
View raw message