perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [patch] C implementation of $r->content + rfc on the name
Date Tue, 20 May 2003 06:45:40 GMT

>>I thought that since this is an input stream, chances are that 99.9% of the 
>>traffic will be plain HEAP buckets. POST data is always coming fully attached. 
>>So it should be safe to force using the length.
> 
> 
> I didn't check the code, but I do seem to remember that
> core_input_filter will insert a socket bucket (the tcp connection) in
> the input chain.
> 
> And I would expect that callign apr_brigade_length on that with the '1'
> flag could potentially result in a blocking call to apr_bucket_read if
> apr_brigade_length is reading in APR_BLOCK_READ mode.
> 
> It does make sense in a way. If the data is coming from a slow client,
> you'll need to read it all in before you can figure out what it's size
> is.

Then it's a bad idea. Your other suggestion to have a good get_client_block 
seems to be ok. But I think that it's faster to process bucket brigades 
directly, since you never need to split buckets.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message