perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [Patch] MP_GTOP=1
Date Mon, 19 May 2003 03:55:56 GMT
How come we don't see any gcc-3.3-compiency patches, yet? ;)

Philippe M. Chiasson wrote:
> # $Id: gtop.patch,v 1.1 2003/05/19 03:29:19 gozer Exp $
> 
> Recently tried building with MP_GTOP=1 and noticed that things don't quite
> work for me anymore. As per gcc documentation __func__ and __FUNCTION__ should not
> be used in string concatenation. 

Then the API should be changed to either accept 2 strings, or (...). Probably 
the former will do, with a second argument being an optional NULL. Whereas 
your patch removes important info.

> Also in modperl_imterp, encountered some
> scfg without a valid gtop structure, so create it if not already there.

+1 (as a separate patch), but let me repeat: identation, identation, identation

> Index: src/modules/perl/mod_perl.c
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/mod_perl.c,v
> retrieving revision 1.170
> diff -u -b -B -I$Id -r1.170 mod_perl.c
> --- src/modules/perl/mod_perl.c	2 May 2003 01:35:03 -0000	1.170
> +++ src/modules/perl/mod_perl.c	19 May 2003 03:25:48 -0000
> @@ -147,8 +147,10 @@
>  
>  #ifdef MP_USE_GTOP
>      MP_TRACE_m_do(
> +        if(!scfg->gtop) {
>          scfg->gtop = modperl_gtop_new(p);
> -        modperl_gtop_do_proc_mem_before(MP_FUNC ": perl_parse");
> +        }
> +        modperl_gtop_do_proc_mem_before(MP_FUNC);

tabs?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message