perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject [patch] lib/Apache/Build.pm
Date Thu, 28 Nov 2002 09:31:52 GMT
Ian Stuart hasn't replied whether my proposed patch solved the problem, 
but I've verified that the problem is real and should be addressed.

Is my solution portable? I'm afraid 'test -d' is not very cross-platform.

-------- Original Message --------
Subject: Re: [mp 2] Bug report - mod-perl install process.
Date: Mon, 11 Nov 2002 23:41:53 +0800

Ian Stuart wrote:
 > Server Version: Apache/2.0.39 (Unix) mod_perl/1.99_07-dev Perl/v5.6.1
 >
 > I believe that the install process does not test for the presence (or
 > lack of..) of the <apache_server_root>/modules directory.
 >
 > This causes a problem during the mod_perl installation as the
 > pseudo-command "cp $SOURCE/mod_perl.so $SERVER/modules" creates a large
 > file called "modules", not a file called "mod_perl.so" within a
 > directory called "modules"
[...]

Indeed, it doesn't. Thanks for the report.

Does the following patch solve the problem? I'm not quite sure how
portable it is, but neither ExtUtils::MakeMaker nor %Config provide
entries for test_d and mkdir.

Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.107
diff -u -r1.107 Build.pm
--- lib/Apache/Build.pm 29 Aug 2002 02:00:56 -0000      1.107
+++ lib/Apache/Build.pm 11 Nov 2002 15:37:06 -0000
@@ -1057,6 +1057,7 @@
   lib: $(MODPERL_LIB)

   install:
+       test -d $(MODPERL_AP_LIBEXECDIR) || mkdir $(MODPERL_AP_LIBEXECDIR)
          $(MODPERL_TEST_F) $(MODPERL_LIB_DSO) && \
          $(MODPERL_CP) $(MODPERL_LIB_DSO) $(MODPERL_AP_LIBEXECDIR)


-- 


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

-- 


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message