perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: cvs commit: modperl-2.0/src/modules/perl modperl_config.c
Date Tue, 20 Nov 2001 03:33:16 GMT
On Tue, 20 Nov 2001, Stas Bekman wrote:
 
> exactly for the same reason that addn() should be used. 
> apr_table_overlay  uses setn() which will loose all pairs with the same 
> key but the last one added.
> 
> apr_table_overlay:
>   *  for (i = 0; i < barr->nelts; ++i) {
>   *      if (flags & APR_OVERLAP_TABLES_MERGE) {
>   *          apr_table_mergen(a, belt[i].key, belt[i].val);
>   *      }
>   *      else {
>   *          apr_table_setn(a, belt[i].key, belt[i].val);
>              ^^^^^^^^^^^^^^^
>   *      }
>   *  }

that is not apr_table_overlay(), that is apr_table_overlap().
and the current version of overlap uses addn().

i think we should be using apr_table_overlay() just as 1.x does, no?



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message