perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: [Patch] $r->pnotes() take 2
Date Tue, 13 Nov 2001 18:01:43 GMT
On Tue, 13 Nov 2001, Philippe M. Chiasson wrote:

> Following Stas comments, here is a revised patch.

thanks, that's in.
 
> One question left though, when we have an accessor method like
> 
> $r->pnotes('key','value');
> 
> Should it return the old or the new values ? 

it should do whatever 1.x does.
 
> +    if (!rcfg)
> +	    return &PL_sv_undef;
> +    
> +    if (!rcfg->pnotes)
> +        rcfg->pnotes = newHV();

and just a friendly reminder, needed to add {}'s for style here.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message