perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: modperl-2.0/src/modules/perl modperl_config.c
Date Tue, 20 Nov 2001 03:22:36 GMT
Doug MacEachern wrote:

> On Mon, 19 Nov 2001, Stas Bekman wrote:
>  
> 
>>yes, that's a bug, must be addn()
>>
> 
> remind me why we don't just use apr_table_overlay like 1.x does for SetVar?

exactly for the same reason that addn() should be used. 
apr_table_overlay  uses setn() which will loose all pairs with the same 
key but the last one added.

apr_table_overlay:
  *  for (i = 0; i < barr->nelts; ++i) {
  *      if (flags & APR_OVERLAP_TABLES_MERGE) {
  *          apr_table_mergen(a, belt[i].key, belt[i].val);
  *      }
  *      else {
  *          apr_table_setn(a, belt[i].key, belt[i].val);
             ^^^^^^^^^^^^^^^
  *      }
  *  }

of course this function should be better moved to APR.

_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:stas@stason.org  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message