perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: cvs commit: modperl-2.0/src/modules/perl mod_perl.c
Date Thu, 12 Apr 2001 15:50:10 GMT
On Thu, 12 Apr 2001, Vivek Khera wrote:

> >>>>> "EC" == Eric Cholet <cholet@logilune.com> writes:
> 
> >> -    if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
> >> +    if ((handles = modperl_xs_dl_handles_get(cdata->pool))) {
> >> modperl_xs_dl_handles_close(handles);
> 
> EC> I did fixed unbalanced parens, you just added another level of parens,
> EC> I wonder why?
> 
> The extra parens shut up gcc's extra warnings, telling it that you
> know it is an assignment, not a typo of == comparison.

exactly.  looking closer at the change eric made, he's right, there were
unbalanced parens:
diff -u -r1.43 -r1.44
--- src/modules/perl/mod_perl.c 2001/04/09 23:57:22     1.43
+++ src/modules/perl/mod_perl.c 2001/04/10 13:55:51     1.44
@@ -14,7 +14,7 @@
     perl_destruct(perl);
     perl_free(perl);
 
-    if ((handles = modperl_xs_dl_handles_get(cdata->pool)) {
+    if (handles = modperl_xs_dl_handles_get(cdata->pool)) {
         modperl_xs_dl_handles_close(handles);
     }
 
not sure how that happened.  but in any case, to we needed an extra paren
on the right hand side, not to remove the one on the left.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message