perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: Config directive segfaults
Date Sun, 18 Feb 2001 20:54:20 GMT
On Fri, 16 Feb 2001, Matt Sergeant wrote:

> This seems to fix it:
... 
> I'm not sure its the right fix, but my server doesn't segfault any more

its not the right fix, as it looks like you've already discovered :)
you should be able to get by for the moment with 1.24_01's
Apache::ExtUtils.  unless you have LoadModule's configured, which is
what the 1.25 change was try to fix.  i tried like hell on friday to
reproduce the problem with 1.25's, but everything works fine for me.  i
don't doubt the bug is there, i'll try again on another machine in the
office tommorrow.  if you're up for it, could you see if the patch below
(against 1.25) helps at all?

Index: lib/Apache/ExtUtils.pm
===================================================================
RCS file: /home/cvs/modperl/lib/Apache/ExtUtils.pm,v
retrieving revision 1.22
diff -u -r1.22 ExtUtils.pm
--- lib/Apache/ExtUtils.pm	2000/12/30 05:08:57	1.22
+++ lib/Apache/ExtUtils.pm	2001/02/16 23:30:53
@@ -263,6 +263,9 @@
         /* need to remove the module so module index is reset */
         remove_module(&XS_${modname});
     }
+    else {
+        return;
+    }
     if (data) {
         /* make sure BOOT section is re-run on restarts */
         (void)hv_delete(GvHV(incgv), this_module,
@@ -285,11 +288,6 @@
     register_cleanup(perl_get_startup_pool(), (void *)1,
                      remove_module_cleanup, null_cleanup);
 
-void
-END()
-
-    CODE:
-    remove_module_cleanup(NULL);
 EOF
 }
 


Mime
View raw message