perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John K Sterling <sterl...@covalent.net>
Subject Re: [PATCH] win32 module names now like unix
Date Sun, 31 Dec 2000 18:26:45 GMT
Sorry about the delay --

finally got a second to breath and test out this patch randy.

It looks great - +1 on a commit before 1.25 doug.

one nitpick - INSTALL.win32:95 still references ApacheModulePerl.dll....
i like the message at the end of running perl Makefile.PL explaining the name
change.

sterling

Randy Kobes wrote:

> ----- Original Message -----
> From: "John K Sterling" <sterling@covalent.net>
> To: "Randy Kobes" <randy@theoryx5.uwinnipeg.ca>
> Cc: <dev@perl.apache.org>
> Sent: Friday, December 22, 2000 7:29 PM
> Subject: Re: [PATCH] win32 module names now like unix
>
> > sounds great randy - do what you gotta do - i'll check it out on the other
> end
> > testing/proofing
> >
> > sterling
> >
>
> Hi,
>     From your earlier patches, it occurred to me that if we're
> going to go to this mod_perl.so convention, how about renaming
> all things that reference ApacheModulePerl, for consistency?
> For example, the attached tar.gz file, which unpacks into
>     src/modules/win32/mod_perl.mak
>     src/modules/win32/mod_perl.def
>     src/modules/win32/mod_perl.dsp
> could replace the current
>     src/modules/ApacheModulePerl/ApacheModulePerl.mak
>     src/modules/ApacheModulePerl/ApacheModulePerl.def
>     src/modules/ApacheModulePerl/ApacheModulePerl.dsp
> In these I incorporated your earlier patches to the .dsp
> and .mak files to build a mod_perl.so.
>
> This would mean some other changes; these are
> in the attached win32.diff file. To summarize,
> - Makefile.PL: use the src/modules/win32/* structure, as
> well as incorporating your patch to find the Apache lib
> in the new location for 1.3.15. This also will, according
> to the apache version, install mod_perl.so as mod_perl.so
> or as ApacheModulePerl.dll, if INSTALL_DLL is passed
> to Makefile.PL.  Finally, a message is printed out at the
> end mentioning the new convention.
> - INSTALL.win32: mention the new convention, as well
> as change references from ApacheModulePerl.dll to
> mod_perl.so.
> - MANIFEST: changes the dsp file name
> - t/* files: makes some changes to load mod_perl.so,
> rather than ApacheModulePerl.dll.
>
> I tried this out on both apache_1.3.15 and apache_1.3.12,
> and it worked, but if you have a chance to try it ....
>
> best regards,
> randy
>
>   ------------------------------------------------------------------------
>                    Name: win32.tar.gz
>    win32.tar.gz    Type: Unix Tape Archive (application/x-tar)
>                Encoding: base64
>
>                  Name: win32.diff
>    win32.diff    Type: unspecified type (application/octet-stream)
>              Encoding: quoted-printable
>
>   ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message