Mailing-List: contact users-help@pdfbox.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@pdfbox.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <54F1F3A1.90705@t-online.de>
Date: Sat, 28 Feb 2015 17:58:09 +0100
From: Tilman Hausherr <THausherr@t-online.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: users@pdfbox.apache.org
Subject: Re: Xref parsing performance
References: 
 <CANs-Dhv9o+=R27jiOATv0Z1B1fRONzupmHq3yNEnyW4amqonXw@mail.gmail.com>
 <54F1E2FA.30402@t-online.de> <54F1EDA1.8090608@lehmi.de>
 <47866D84-49D0-4674-A983-8386BA3263C0@fileaffairs.de>
In-Reply-To: <47866D84-49D0-4674-A983-8386BA3263C0@fileaffairs.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Am 28.02.2015 um 17:49 schrieb Maruan Sahyoun:
>>> >>
>>> >>- why change only one of the members of that cosobjectkey class to int?
>>> >>According to the spec, both are integers. Maybe there's a good reason, but I'd
>>> >>like to know.
>> >ASFAIK there is no good reason not to change both to int.
> as the offset is a 10 digit number is that really covered being an int?

I would have waited for his explanation... and now I understand what he 
may have thought - consider this change you did:

-                                        new COSObjectKey(-fileOffset, 0));
+                                        new COSObjectKey((int)-fileOffset, 0));

the first paramater has a double usage within PDFBox, if negative it is 
an offset in an object stream. Do we know that these are always smaller 
than 0x7FFFFFFF ?

Tilman

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: users-help@pdfbox.apache.org