From dev-return-66292-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Thu Nov 14 17:07:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 44740180607 for ; Thu, 14 Nov 2019 18:07:08 +0100 (CET) Received: (qmail 99666 invoked by uid 500); 14 Nov 2019 17:07:03 -0000 Mailing-List: contact dev-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list dev@pdfbox.apache.org Received: (qmail 99430 invoked by uid 99); 14 Nov 2019 17:07:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Nov 2019 17:07:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B7BD2E30A8 for ; Thu, 14 Nov 2019 17:07:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 7CEC8780559 for ; Thu, 14 Nov 2019 17:07:00 +0000 (UTC) Date: Thu, 14 Nov 2019 17:07:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: dev@pdfbox.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PDFBOX-3017) Improve document signing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PDFBOX-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974442#comment-16974442 ] ASF subversion and git services commented on PDFBOX-3017: --------------------------------------------------------- Commit 1869805 from Tilman Hausherr in branch 'pdfbox/branches/issue45' [ https://svn.apache.org/r1869805 ] PDFBOX-3017: refactor previous commit > Improve document signing > ------------------------ > > Key: PDFBOX-3017 > URL: https://issues.apache.org/jira/browse/PDFBOX-3017 > Project: PDFBox > Issue Type: Improvement > Components: AcroForm, Signing > Affects Versions: 2.0.0, 3.0.0 PDFBox > Reporter: Tilman Hausherr > Priority: Major > Fix For: 3.0.0 PDFBox > > Attachments: PDFBOX-3017_certificate_chain.diff, PDFBOX-3017_certificate_chain_Screenshot.png, QV_RCA1_RCA3_CPCPS_V4_11.pdf, SO52757037-Signed3-OCSP-with-KeyHash.pdf, pdfa_signed_insivible.pdf > > > Improve signing code: > - incremental save only works for signatures and doesn't respect certificates such as Adobe Extended Usage Rights > - -{{prepareNonVisualSignature}} clears the AcroForm DR {{acroForm.setDefaultResources(null)}} which is not good if there are other form fields- > - visual/nonVisualSignature should move into the {{interactive.forms}} package and be handled within the signature field > - -verify signature (to have tests that go full circle)- done June 2016 > - document or refactor / rewrite visible labyrinthine signature code > - why is it not possible to pass only the signatureField to addSignature, instead having to create a COSDocument with a page and annotations that has the signature field, and that must be searched for in {{prepareVisibleSignature()}}? > - -support rotated pages (see https://stackoverflow.com/questions/34012293/pdfbox-sign-landscape-file-error/34359956#34359956 )- done in PDFBOX-3671 > - -make sure that signed PDF/A files are still PDF/A (see http://www.pdfa.org/wp-content/uploads/2011/08/tn0006_digital_signatures_in_pdfa-1_2008-03-14.pdf ); /ID possibly not OK; /Annots is possibly required ([~tilman] removed this for invisible signatures); test signed files with PDF-Tools and with preflight- tested, they are OK with PDF-Tools and preflight > - test whether "bad" signatures are detected by preflight (search in old issues) > - -PDFBOX-3363 - why is the stream cached in a file? Should it be done in memory?- done on July 15, 2016 > - remove {{setVisualSignature(PDVisibleSigProperties visSignatureProperties)}} from SignatureOptions.java, all it does is to call {{visSignatureProperties.getVisibleSignature()}} which returns an {{InputStream}}, and this is already available > - {{checkSignatureField}} violates the "do one thing" rule > - -decide whether the whole certificate chain should be passed in the sample code, instead of only the first one- yes the whole chain is stored > - -check certificate chain, revocation lists, etc,- only if needed by users, code [here|https://svn.apache.org/repos/asf/cxf/tags/cxf-2.4.1/distribution/src/main/release/samples/sts_issue_operation/src/main/java/demo/sts/provider/cert/] > - deprecate / remove all PDVisibleSignDesigner constructors except those with a PDDocument object, to avoid a file being opened twice > - ... your ideas... -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org For additional commands, e-mail: dev-help@pdfbox.apache.org