From dev-return-64682-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Wed Aug 7 17:53:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 07FE8180674 for ; Wed, 7 Aug 2019 19:53:01 +0200 (CEST) Received: (qmail 91709 invoked by uid 500); 7 Aug 2019 17:53:01 -0000 Mailing-List: contact dev-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list dev@pdfbox.apache.org Received: (qmail 91588 invoked by uid 99); 7 Aug 2019 17:53:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Aug 2019 17:53:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63C6AE2FC9 for ; Wed, 7 Aug 2019 17:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1FD3226666 for ; Wed, 7 Aug 2019 17:53:00 +0000 (UTC) Date: Wed, 7 Aug 2019 17:53:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@pdfbox.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PDFBOX-4625) remove Netbeans warning: Exporting non-public type through public API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PDFBOX-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902353#comment-16902353 ] ASF subversion and git services commented on PDFBOX-4625: --------------------------------------------------------- Commit 1864654 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1864654 ] PDFBOX-4625: remove public when parameter class is package-private > remove Netbeans warning: Exporting non-public type through public API > --------------------------------------------------------------------- > > Key: PDFBOX-4625 > URL: https://issues.apache.org/jira/browse/PDFBOX-4625 > Project: PDFBox > Issue Type: Task > Components: FontBox > Affects Versions: 2.0.16 > Reporter: Tilman Hausherr > Assignee: Tilman Hausherr > Priority: Minor > Labels: Netbeans > Fix For: 2.0.17, 3.0.0 PDFBox > > > Netbeans brings me the "Exporting non-public type through public API" warning, because in lines like > {code} > public void read(TrueTypeFont ttf, TTFDataStream data) throws IOException > {code} > the method is public despite that TTFDataStream is package-private. The solution would be to remove the "public". While the current situation brings no real harm, it bloats the javadoc and confuses the reader, as the method cannot be used from outside. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org For additional commands, e-mail: dev-help@pdfbox.apache.org