pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PDFBOX-4625) remove Netbeans warning: Exporting non-public type through public API
Date Wed, 07 Aug 2019 17:14:00 GMT

    [ https://issues.apache.org/jira/browse/PDFBOX-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902260#comment-16902260
] 

ASF subversion and git services commented on PDFBOX-4625:
---------------------------------------------------------

Commit 1864646 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1864646 ]

PDFBOX-4625: remove public when parameter class is package-private

> remove Netbeans warning: Exporting non-public type through public API
> ---------------------------------------------------------------------
>
>                 Key: PDFBOX-4625
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4625
>             Project: PDFBox
>          Issue Type: Task
>          Components: FontBox
>    Affects Versions: 2.0.16
>            Reporter: Tilman Hausherr
>            Assignee: Tilman Hausherr
>            Priority: Minor
>              Labels: Netbeans
>             Fix For: 2.0.17, 3.0.0 PDFBox
>
>
> Netbeans brings me the "Exporting non-public type through public API" warning, because
in lines like
> {code}
> public void read(TrueTypeFont ttf, TTFDataStream data) throws IOException
> {code}
> the method is public despite that TTFDataStream is package-private. The solution would
be to remove the "public". While the current situation brings no real harm, it bloats the
javadoc and confuses the reader, as the method cannot be used from outside.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


Mime
View raw message