pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maruan Sahyoun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PDFBOX-4617) PDButton.setValue and PDButton.getOnValueForWidget cannot handle radios with duplicate names and choices
Date Sat, 03 Aug 2019 17:23:00 GMT

    [ https://issues.apache.org/jira/browse/PDFBOX-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899493#comment-16899493
] 

Maruan Sahyoun commented on PDFBOX-4617:
----------------------------------------

Given the form labels and the description it's not clear what would be the expected behaviour

None of the radio buttons has the option no/yes assigned to it. So using no/yes when setting
the value won't work. I think from the comments that's also not expected.

Given that some of the labels are used for multiple radio buttons would it be expected that
setting the value of one of the 'choice: yes' selects all of them? If that is the case there
is one setting missing - to select in unison.

For the possible opt values of the group the information is given (off, 0, Choice2).
To get the information for individual ones one would need to expect the setting of the /Kids

Obviously there is an issue here as the current code works under the assumption that Radio
buttons are selected in unison which isn't the case here




> PDButton.setValue and PDButton.getOnValueForWidget cannot handle radios with duplicate
names and choices
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4617
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4617
>             Project: PDFBox
>          Issue Type: Bug
>          Components: AcroForm
>    Affects Versions: 2.0.16
>            Reporter: Rosalind Douglas
>            Priority: Major
>         Attachments: Radio buttons with duplicate names and choices.pdf
>
>
> Hello, thank you for all of your efforts in building and maintaining PDFBox. We use it
extensively for parsing PDFs, programmatically setting values and flattening PDFs for print.
> BUG: When we parse the attached PDF, the onvalues for the radio buttons are 0, 1, 2,
3, 4, which are determined by PDButton.getOnValueForWidget. Later on, when we try to programmatically
set the value of the radio buttons (PDField.setValue) using the above onvalues, we receive
this error:
> {code:java}
> 2019-07-31 08:59:36 ERROR (Prism.java:3744)- STACK: java.lang.IllegalArgumentException:
value '1' is not a valid option for the field radio1, valid values are: [no, yes] and Off
at org.apache.pdfbox.pdmodel.interactive.form.PDButton.checkValue(PDButton.java:376) ~[pdfbox-2.0.16.jar:2.0.16]
at org.apache.pdfbox.pdmodel.interactive.form.PDButton.setValue(PDButton.java:158) ~[pdfbox-2.0.16.jar:2.0.16]
> {code}
> The radio buttons all have the same name, with either "yes" or "no" as the choice value.
We would expect it to behave like Adobe DC, which allows the user to select any of the buttons
regardless of whether they have the same choice or not. I am on PDFBox 2.0.16.
> Though my example might seem trivial, it's very easy for our PDF creating users to do
this because copying and pasting fields is the easiest way to build a PDF.
> PROPOSED FIX: 
> This might be a regression caused by PDFBOX-3391. In our code, we have overridden the
PDButton.setValue method so that it always invokes updateByValue(value) rather than sometimes
using updateByOption(value). Here is the code that works for us, from PDButton.setValue(String
value):
>  
> {code:java}
> @Override public void setValue(String value) throws IOException { 
> checkValue(value); 
> updateByValue(value); 
> applyChange(); }
> {code}
>  
> One caveat is that the change would probably break your PDFBOX-3391 fix, but perhaps
there's some way to have them live side by side. I don't know very much about the other problem.
> Thanks again,
> Rosalind
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


Mime
View raw message