pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "beat weisskopf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PDFBOX-4398) getLastSignatureDictionary modifies internal structure of PDDocument
Date Thu, 06 Dec 2018 12:25:00 GMT

    [ https://issues.apache.org/jira/browse/PDFBOX-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711372#comment-16711372

beat weisskopf commented on PDFBOX-4398:

I won't do anything for now.

That's ok for me. Thanks for all the work!

> getLastSignatureDictionary modifies internal structure of PDDocument
> --------------------------------------------------------------------
>                 Key: PDFBOX-4398
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4398
>             Project: PDFBox
>          Issue Type: Bug
>          Components: AcroForm
>    Affects Versions: 2.0.12
>            Reporter: beat weisskopf
>            Priority: Minor
>             Fix For: 3.0.0 PDFBox
> If one calls PDDocument#getLastSignatureDictionary, the AcroFrom is populated with the
defaults even if not needed. This modifies the internals of the PDDocument and therefore there
are changes to be saved, even if the file is not modified by "real" changes.
> For example:
> {code}
>             PDDocument pdfDocument = PDDocument.load(pdfBytes);
>             pdfDocument.getLastSignatureDictionary();
> {code}
> This calls the verifyOrCreateDefaults() method, which initializes the DR-Dictionary if
not yet done. This is even done if getLastSignatureDictionary returns null.
> Why this bothers me: it is very unexpected behaviour that a getter modifies an objects
state. This is no big deal for our usecase, the other issue (PDFBOX-4303) was a bigger problem
as we are diffing objects between revisions (current vs last signed revision).

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org

View raw message