pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tilman Hausherr <THaush...@t-online.de>
Subject Re: [VOTE] Release Apache PDFBox 1.8.16
Date Tue, 02 Oct 2018 17:03:03 GMT
Am 02.10.2018 um 18:46 schrieb Andreas Lehmkuehler:
>
> That was fixed in 2.0.0 but the last 2 commits didn't make it into the 
> 1.8 branch, see PDFBOX-2619 for details
>
> IMHO, this is a minor issue and we should proceed with the release.
>
> WDTY?

IMHO This is minor. I still don't understand what happened - does it 
mean the build only fails in the US? Why didn't it fail on the apache 
servers?

Tilman


>
>
>
> Am 02.10.2018 um 15:54 schrieb Tim Allison:
>> Not a Java version or OS issue.  This is an internationalization 
>> issue. :)
>>
>> This is the date String that's going into the COSDict: 
>> 20181002094558-04'00'
>>
>> SynchronizedMetaDataValidation's hasTimeZone(Object date)
>> is returning false for that but true for the Calendar in XMP.
>>
>> The regex in hasTimeZone(Object date) looks for dates _after_ GMT, 
>> not before.
>>
>> Change this:
>> final String datePattern =
>> "^D:.*[Z]$|^D:.*\\+.*|^\\d{4}.*T.*Z$|^\\d{4}.*T.*[\\+]\\d{2}.*$";
>>
>> to:
>>
>> final String datePattern =
>> "^D:.*[Z]$|^D:.*[-+].*|^\\d{4}.*T.*Z$|^\\d{4}.*T.*[-+]\\d{2}.*$";
>>
>> and the build works in my timezone! I don't know if D:.*[-+].* will 
>> be too lax?
>> On Mon, Oct 1, 2018 at 6:57 PM Tim Allison <tallison@apache.org> wrote:
>>>
>>> That might explain it.
>>>
>>> java version "1.8.0_181"
>>> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
>>> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
>>> On Mon, Oct 1, 2018 at 5:25 PM Andreas Lehmkuehler 
>>> <andreas@lehmi.de> wrote:
>>>>
>>>> Am 01.10.2018 um 23:07 schrieb Tim Allison:
>>>>> Could be user error, but I'm getting three test failures in
>>>>> TestSynchronizedMetadataValidation.
>>>> What jdk are you using? I had some issues when it comes to 
>>>> particular version
>>>> especially openjdk vs sun jdk.
>>>>
>>>> Andreas
>>>>
>>>>>
>>>>> junit.framework.AssertionFailedError
>>>>> at junit.framework.Assert.fail(Assert.java:55)
>>>>> at junit.framework.Assert.assertTrue(Assert.java:22)
>>>>> at junit.framework.Assert.assertTrue(Assert.java:31)
>>>>>
>>>>>
>>>>> junit.framework.AssertionFailedError:
>>>>> Expected :0
>>>>> Actual   :2
>>>>>    <Click to see difference>
>>>>>
>>>>>
>>>>> at junit.framework.Assert.fail(Assert.java:57)
>>>>> at junit.framework.Assert.failNotEquals(Assert.java:329)
>>>>> at junit.framework.Assert.assertEquals(Assert.java:78)
>>>>> at junit.framework.Assert.assertEquals(Assert.java:234)
>>>>> at junit.framework.Assert.assertEquals(Assert.java:241)
>>>>> at 
>>>>> org.apache.pdfbox.preflight.metadata.TestSynchronizedMetadataValidation.testAllInfoSynhcronized
>>>>>
>>>>>
>>>>> Expected :7.4.2
>>>>> Actual   :7.2
>>>>>    <Click to see difference>
>>>>>
>>>>>
>>>>> at junit.framework.Assert.assertEquals(Assert.java:100)
>>>>> at junit.framework.Assert.assertEquals(Assert.java:107)
>>>>> at 
>>>>> org.apache.pdfbox.preflight.metadata.TestSynchronizedMetadataValidation.testBadPrefixSchemas
>>>>> On Mon, Oct 1, 2018 at 3:04 PM Andreas Lehmkuehler 
>>>>> <andreas@lehmi.de> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> a candidate for the PDFBox 1.8.16 release is available at:
>>>>>>
>>>>>> https://dist.apache.org/repos/dist/dev/pdfbox/1.8.16/
>>>>>>
>>>>>> The release candidate is a zip archive of the sources in:
>>>>>>
>>>>>> http://svn.apache.org/repos/asf/pdfbox/tags/1.8.16/
>>>>>>
>>>>>> The SHA-512 checksum of the archive is
>>>>>> 85fbb9ef611876566f4bca626328af1e6c2ee9e9fddf18f589c110042727c15fa301d693b5f397bdbfb41e245502f40b9b2edb7dc691ccbe3e9f57a5aee8061e.

>>>>>>
>>>>>>
>>>>>> Please vote on releasing this package as Apache PDFBox 1.8.16.
>>>>>> The vote is open for the next 72 hours and passes if a majority 
>>>>>> of at
>>>>>> least three +1 PDFBox PMC votes are cast.
>>>>>>
>>>>>>        [ ] +1 Release this package as Apache PDFBox 1.8.16
>>>>>>        [ ] -1 Do not release this package because...
>>>>>>
>>>>>> Here his my +1
>>>>>>
>>>>>> Andreas
>>>>>>
>>>>>> ---------------------------------------------------------------------

>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
>>>>>> For additional commands, e-mail: dev-help@pdfbox.apache.org
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
>>>>> For additional commands, e-mail: dev-help@pdfbox.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
>>>> For additional commands, e-mail: dev-help@pdfbox.apache.org
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
>> For additional commands, e-mail: dev-help@pdfbox.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
> For additional commands, e-mail: dev-help@pdfbox.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


Mime
View raw message