Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4489E200CB8 for ; Sat, 1 Jul 2017 18:19:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 43394160BEA; Sat, 1 Jul 2017 16:19:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B0D43160BD2 for ; Sat, 1 Jul 2017 18:19:52 +0200 (CEST) Received: (qmail 55601 invoked by uid 500); 1 Jul 2017 16:19:51 -0000 Mailing-List: contact dev-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list dev@pdfbox.apache.org Received: (qmail 55590 invoked by uid 99); 1 Jul 2017 16:19:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Jul 2017 16:19:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8295FDFF18; Sat, 1 Jul 2017 16:19:51 +0000 (UTC) From: skjolber To: dev@pdfbox.apache.org Reply-To: dev@pdfbox.apache.org Message-ID: Subject: [GitHub] pdfbox pull request #38: one-time array sanity check for use with OperatorPr... Content-Type: text/plain Date: Sat, 1 Jul 2017 16:19:51 +0000 (UTC) archived-at: Sat, 01 Jul 2017 16:19:53 -0000 GitHub user skjolber opened a pull request: https://github.com/apache/pdfbox/pull/38 one-time array sanity check for use with OperatorProcessor Input for https://github.com/apache/pdfbox/pull/27 (PR not indented for merge). The unit tests seem to work fine with the one-time array. This approach has the limitation that it relies on test coverage. Manual inspection seems to verify that the passed array is not saved, however some ArrayList.sublist(..) calls exist; in the arraylist implementation these relay on the parent array. However these are not kept either. You can merge this pull request into a Git repository by running: $ git pull https://github.com/skjolber/pdfbox optimization_validator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/pdfbox/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 ---- commit 2fe6bce16cc3e8a6cbba5581baba61116775d592 Author: Thomas Skjølberg Date: 2017-07-01T15:22:54Z one-time array sanity check for use with OperatorProcessor ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org For additional commands, e-mail: dev-help@pdfbox.apache.org