pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skjolber <...@git.apache.org>
Subject [GitHub] pdfbox pull request #38: one-time array sanity check for use with OperatorPr...
Date Sat, 01 Jul 2017 16:19:51 GMT
GitHub user skjolber opened a pull request:

    https://github.com/apache/pdfbox/pull/38

    one-time array sanity check for use with OperatorProcessor

    Input for https://github.com/apache/pdfbox/pull/27 (PR not indented for merge). The unit
tests seem to work fine with the one-time array. This approach has the limitation that it
relies on test coverage. 
    
    Manual inspection seems to verify that the passed array is not saved, however some ArrayList.sublist(..)
calls exist; in the arraylist implementation these relay on the parent array. However these
are not kept either.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skjolber/pdfbox optimization_validator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/pdfbox/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 2fe6bce16cc3e8a6cbba5581baba61116775d592
Author: Thomas SkjĂžlberg <thomas.skjolberg@gmail.com>
Date:   2017-07-01T15:22:54Z

    one-time array sanity check for use with OperatorProcessor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


Mime
View raw message