Return-Path: X-Original-To: apmail-pdfbox-dev-archive@www.apache.org Delivered-To: apmail-pdfbox-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2588410D7F for ; Sun, 5 Jan 2014 13:47:56 +0000 (UTC) Received: (qmail 45193 invoked by uid 500); 5 Jan 2014 13:47:53 -0000 Delivered-To: apmail-pdfbox-dev-archive@pdfbox.apache.org Received: (qmail 45164 invoked by uid 500); 5 Jan 2014 13:47:51 -0000 Mailing-List: contact dev-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list dev@pdfbox.apache.org Received: (qmail 45151 invoked by uid 99); 5 Jan 2014 13:47:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Jan 2014 13:47:50 +0000 Date: Sun, 5 Jan 2014 13:47:50 +0000 (UTC) From: "Tilman Hausherr (JIRA)" To: dev@pdfbox.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PDFBOX-1831) [PATCH] Fix: "Foreign" characters are not rendered MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PDFBOX-1831?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D138= 62557#comment-13862557 ]=20 Tilman Hausherr commented on PDFBOX-1831: ----------------------------------------- Wow great! It works for two files ("bimbo" and "foris" files), but does not= work for two (page 3 of the "1822" file, and the "centerplan" file of PDFB= OX-615, see near the bottom left at "und M=C3=BClheim die Linien 138 und 14= 5", the "=C3=BC" is missing. Did the 1822 file work for you? (I ask to be s= ure that I didn't simply forgot something) Look for the number "12" in the = middle of the image, at the left there's a missing "=C3=B6", at the right t= he "=C3=BC"s are missing but the "=C3=A4" are all there?! > [PATCH] Fix: "Foreign" characters are not rendered > -------------------------------------------------- > > Key: PDFBOX-1831 > URL: https://issues.apache.org/jira/browse/PDFBOX-1831 > Project: PDFBox > Issue Type: Bug > Components: FontBox > Affects Versions: 2.0.0 > Reporter: John Hewson > Labels: patch > Attachments: 1822-agb.pdf-3.png, StandardEncoding.java, Type1Char= String.java, Type2CharString.java, diff.patch > > > This is a patch to fix PDFBOX-1691, I've opened it as its own issue becau= se it's quite a large patch. > The issue it fixes is that the Type 1 "seac" command was not implemented.= Seac is a command which draws a composite glyph from two other glyphs. Thi= s requires that the Type 1 renderer has access to any of the other rendered= glyphs in a CFFFont, which is why this patch is non-trivial. The major cha= nge is that the CharStringRenderer has been refactored into a new Type1Char= String class and the CharStringConverter has been refactored into a new Typ= e2CharString class. A lot of code has been moved around, but overall this i= s a conservative patch, as most of the code has not changed significantly. > As well as the patch, there are 3 new files: > + fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java > + fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java > + fontbox/src/main/java/org/apache/fontbox/encoding/StandardEncoding.java > and two deleted files: > - fontbox/src/main/java/org/apache/fontbox/cff/CharStringRenderer.java > - fontbox/src/main/java/org/apache/fontbox/cff/CharStringConverter.java -- This message was sent by Atlassian JIRA (v6.1.5#6160)