pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tilman Hausherr (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PDFBOX-1831) [PATCH] Fix: "Foreign" characters are not rendered
Date Sun, 05 Jan 2014 19:09:50 GMT

    [ https://issues.apache.org/jira/browse/PDFBOX-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862635#comment-13862635
] 

Tilman Hausherr commented on PDFBOX-1831:
-----------------------------------------

Thanks, it all works now. And there doesn't seem to be any negative side effect on any of
my test files.

> [PATCH] Fix: "Foreign" characters are not rendered
> --------------------------------------------------
>
>                 Key: PDFBOX-1831
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1831
>             Project: PDFBox
>          Issue Type: Bug
>          Components: FontBox
>    Affects Versions: 2.0.0
>            Reporter: John Hewson
>            Assignee: Andreas Lehmkühler
>              Labels: patch
>             Fix For: 2.0.0
>
>         Attachments: 1822-agb.pdf-3.png, StandardEncoding.java, Type1CharString.java,
Type2CharString.java, diff.patch
>
>
> This is a patch to fix PDFBOX-1691, I've opened it as its own issue because it's quite
a large patch.
> The issue it fixes is that the Type 1 "seac" command was not implemented. Seac is a command
which draws a composite glyph from two other glyphs. This requires that the Type 1 renderer
has access to any of the other rendered glyphs in a CFFFont, which is why this patch is non-trivial.
The major change is that the CharStringRenderer has been refactored into a new Type1CharString
class and the CharStringConverter has been refactored into a new Type2CharString class. A
lot of code has been moved around, but overall this is a conservative patch, as most of the
code has not changed significantly.
> As well as the patch, there are 3 new files:
> + fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java
> + fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java
> + fontbox/src/main/java/org/apache/fontbox/encoding/StandardEncoding.java
> and two deleted files:
> - fontbox/src/main/java/org/apache/fontbox/cff/CharStringRenderer.java
> - fontbox/src/main/java/org/apache/fontbox/cff/CharStringConverter.java



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message