pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Lehmkühler (JIRA) <j...@apache.org>
Subject [jira] [Commented] (PDFBOX-1825) [PATCH] Many pdfbox tests are never run
Date Sat, 11 Jan 2014 12:20:54 GMT

    [ https://issues.apache.org/jira/browse/PDFBOX-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868756#comment-13868756
] 

Andreas Lehmkühler commented on PDFBOX-1825:
--------------------------------------------

- I excluded src/test/resources/output from the rat check in revision 1557363.
- I exclude TestAll from the tests to avoid running some tests twice in revision 1557366

> [PATCH] Many pdfbox tests are never run
> ---------------------------------------
>
>                 Key: PDFBOX-1825
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1825
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 1.8.3, 2.0.0
>            Reporter: John Hewson
>            Assignee: Andreas Lehmkühler
>              Labels: patch, test
>             Fix For: 2.0.0
>
>         Attachments: TestPDFToImage.patch, patch.diff
>
>
> The pdfbox tests are run via the TestAll.java which simply adds all the other tests to
the test suite. However, the TestAll.java has not been kept up to date, so there are 13 tests
which are not run, these are as follows:
> /util
> TestTextStripperPerformance [FAILS]
> TestPDFToImage
> TestPDFText2HTML
> PageExtractorTest
> /pdmodel/graphics/color
> PDColorStateTest
> /pdmodel/font
> TestTTFParser
> PDSimpleFontTest
> /pdfparser
> TestPDFParser [FAILS]
> TestNonSequentialPDFParser
> ConformingPDFParserTest
> /encryption
> TestPublicKeyEncryption [FAILS]
> /cos
> TestCOSBase
> TestCOSNumber
> I presume that TestAll.java is a legacy file, as Maven is used in all the other sub-projects
to run any tests named Test**.java, the solution is propose is:
> 1. delete AllTests.java
> 2 .the patch changes pom.xml to run Test**.java files automatically
> 3. the patch fixes bugs in the TestImageIOUtils and TestTextStripperPerformance tests
which threw exceptions because their output folder did not exist
> 4. the patch disables the TestPDFToImage and TestPublicKeyEncryption which are broken,
I will open two new issues for fixing these tests



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message