pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tilman Hausherr (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PDFBOX-1825) [PATCH] Many pdfbox tests are never run
Date Sun, 05 Jan 2014 19:00:50 GMT

     [ https://issues.apache.org/jira/browse/PDFBOX-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Tilman Hausherr updated PDFBOX-1825:

    Attachment: TestPDFToImage.patch

This is the diff about what I wrote above. Its not really for production, its more a tool
to see if there are any meaningful differences to previous renderings, and something optional
for the future to test a large amount of files automatically, to detect regressions. I don't
use it regularly because I have observed that there are sometimes tiny differences that aren't
really important. Currently, the test always fails, because at least one of the sample files
isn't rendered correctly, but browsing through the diff graphic files helps to find if there
is something "big".

> [PATCH] Many pdfbox tests are never run
> ---------------------------------------
>                 Key: PDFBOX-1825
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1825
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 1.8.3, 2.0.0
>            Reporter: John Hewson
>              Labels: patch, test
>         Attachments: TestPDFToImage.patch, patch.diff
> The pdfbox tests are run via the TestAll.java which simply adds all the other tests to
the test suite. However, the TestAll.java has not been kept up to date, so there are 13 tests
which are not run, these are as follows:
> /util
> TestTextStripperPerformance [FAILS]
> TestPDFToImage
> TestPDFText2HTML
> PageExtractorTest
> /pdmodel/graphics/color
> PDColorStateTest
> /pdmodel/font
> TestTTFParser
> PDSimpleFontTest
> /pdfparser
> TestPDFParser [FAILS]
> TestNonSequentialPDFParser
> ConformingPDFParserTest
> /encryption
> TestPublicKeyEncryption [FAILS]
> /cos
> TestCOSBase
> TestCOSNumber
> I presume that TestAll.java is a legacy file, as Maven is used in all the other sub-projects
to run any tests named Test**.java, the solution is propose is:
> 1. delete AllTests.java
> 2 .the patch changes pom.xml to run Test**.java files automatically
> 3. the patch fixes bugs in the TestImageIOUtils and TestTextStripperPerformance tests
which threw exceptions because their output folder did not exist
> 4. the patch disables the TestPDFToImage and TestPublicKeyEncryption which are broken,
I will open two new issues for fixing these tests

This message was sent by Atlassian JIRA

View raw message