pdfbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Lehmkühler (JIRA) <j...@apache.org>
Subject [jira] [Commented] (PDFBOX-1105) Integration Test in preflight to make easy validation
Date Tue, 30 Aug 2011 17:49:37 GMT

    [ https://issues.apache.org/jira/browse/PDFBOX-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093934#comment-13093934
] 

Andreas Lehmkühler commented on PDFBOX-1105:
--------------------------------------------

Looks good to me, I like your idea.

Just for the record, the part of the license, which prevents us from placing the files somewhere
else:

"All other rights are reserved, and other uses are not covered by these terms of use. For
clarity, using the Isartor test suite as the basis for certifying third-party products (i.e.
the software vendor/distributor and the certifying agency are separate entities) is not allowed.
Redistributing all or parts of the Isartor test suite is also not allowed."

> Integration Test in preflight to make easy validation
> -----------------------------------------------------
>
>                 Key: PDFBOX-1105
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1105
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Preflight
>            Reporter: Guillaume Bailleul
>            Assignee: Guillaume Bailleul
>             Fix For: 1.7.0
>
>         Attachments: padaf-integ.patch
>
>
> I join a patch that add 3 Test to :
> - check isartor files and check if expected error occurs
> - check invalid files and check (if defined) if expected error occurs
> - check valid files 
> pom.xml is modified to set these test as integration test.
> If nothing is configured, integration phase does not fail.
> If parameters are configured, directories with pdf files are pointed and test should
fail is configuration is invalid
> Parameters are :
> * isartor.files = path of isartor files
> * expected.errors = the file that contains expected error codes (see preflight/src/test/resources/expected_errors.txt)
> * invalid.files = path of directory containing file known as invalid
> * invalid.errors = a file that can contain expected error code for invalid file, this
is not mandatory
> * valid.files = path of directory containing file known as valid
> Use -D... to set parameters.
> I will not commit that patch quickly because I am not sure it is the best way to do.
With this method, there is no PDF/A file in generated artefacts so no licence problem. Anyone
can have his set of file to validate preflight even if I could be a good idea to share when
possible ... But I don't known where.
> So if anyone has suggestion to help ...
> sha1sum : d1694158976f7f6e69f893be149b7a1bb9a6a714  padaf-integ.patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message