From commits-return-19174-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Fri Mar 26 18:41:45 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 2C04B180642 for ; Fri, 26 Mar 2021 19:41:45 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 966EA641BF for ; Fri, 26 Mar 2021 18:41:44 +0000 (UTC) Received: (qmail 61649 invoked by uid 500); 26 Mar 2021 18:41:44 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 61637 invoked by uid 99); 26 Mar 2021 18:41:43 -0000 Received: from Unknown (HELO svn01-us-east.apache.org) (13.90.137.153) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Mar 2021 18:41:43 +0000 Received: from svn01-us-east.apache.org (svn01-us-east.apache.org [127.0.0.1]) by svn01-us-east.apache.org (ASF Mail Server at svn01-us-east.apache.org) with ESMTP id 921B117A215 for ; Fri, 26 Mar 2021 18:41:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1888094 - /pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PrintPDF.java Date: Fri, 26 Mar 2021 18:41:43 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20210326184143.921B117A215@svn01-us-east.apache.org> Author: tilman Date: Fri Mar 26 18:41:43 2021 New Revision: 1888094 URL: http://svn.apache.org/viewvc?rev=1888094&view=rev Log: PDFBOX-4892: refactor, as suggested by valerybokov Modified: pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PrintPDF.java Modified: pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PrintPDF.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PrintPDF.java?rev=1888094&r1=1888093&r2=1888094&view=diff ============================================================================== --- pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PrintPDF.java (original) +++ pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PrintPDF.java Fri Mar 26 18:41:43 2021 @@ -169,12 +169,13 @@ public final class PrintPDF { PrintService[] printServices = PrinterJob.lookupPrintServices(); boolean printerFound = false; - for (int i = 0; !printerFound && i < printServices.length; i++) + for (int i = 0; i < printServices.length; i++) { if (printServices[i].getName().equals(printerName)) { printJob.setPrintService(printServices[i]); printerFound = true; + break; } } if (!printerFound)