From commits-return-15772-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Wed Sep 25 17:54:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 18327180637 for ; Wed, 25 Sep 2019 19:54:30 +0200 (CEST) Received: (qmail 98787 invoked by uid 500); 25 Sep 2019 17:54:30 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 98774 invoked by uid 99); 25 Sep 2019 17:54:30 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Sep 2019 17:54:30 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 443053A05E4 for ; Wed, 25 Sep 2019 17:54:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1867524 - in /pdfbox/trunk: pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java Date: Wed, 25 Sep 2019 17:54:29 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190925175429.443053A05E4@svn01-us-west.apache.org> Author: tilman Date: Wed Sep 25 17:54:29 2019 New Revision: 1867524 URL: http://svn.apache.org/viewvc?rev=1867524&view=rev Log: PDFBOX-4071: use jdk8 lambda expressions and streams Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java?rev=1867524&r1=1867523&r2=1867524&view=diff ============================================================================== --- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java (original) +++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java Wed Sep 25 17:54:29 2019 @@ -24,11 +24,10 @@ import org.junit.runner.RunWith; import org.junit.runners.Parameterized.Parameters; import java.io.File; -import java.io.FilenameFilter; import java.io.IOException; -import java.util.ArrayList; import java.util.Collection; -import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; /** * Functional test for PDF rendering. This test simply tries to render @@ -46,21 +45,9 @@ public class TestRendering @Parameters(name = "{0}") public static Collection data() { - File[] testFiles = new File(INPUT_DIR).listFiles(new FilenameFilter() - { - @Override - public boolean accept(File dir, String name) - { - return (name.endsWith(".pdf") || name.endsWith(".ai")); - } - }); - - List params = new ArrayList<>(); - for (File file : testFiles) - { - params.add(new Object[] { file.getName() }); - } - return params; + File[] testFiles = new File(INPUT_DIR).listFiles( + (dir, name) -> (name.endsWith(".pdf") || name.endsWith(".ai"))); + return Stream.of(testFiles).map(file -> new Object[] { file.getName() }).collect(Collectors.toList()); } private final String fileName; Modified: pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java?rev=1867524&r1=1867523&r2=1867524&view=diff ============================================================================== --- pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java (original) +++ pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java Wed Sep 25 17:54:29 2019 @@ -25,7 +25,6 @@ import java.io.File; import java.io.FileInputStream; import java.io.FileNotFoundException; import java.io.FileOutputStream; -import java.io.FilenameFilter; import java.io.IOException; import java.io.OutputStream; import java.util.HashSet; @@ -292,14 +291,8 @@ public class TestImageIOUtils extends Te throw new IOException("could not create output directory"); } - File[] testFiles = new File(inDir).listFiles(new FilenameFilter() - { - @Override - public boolean accept(File dir, String name) - { - return (name.endsWith(".pdf") || name.endsWith(".ai")); - } - }); + File[] testFiles = new File(inDir).listFiles( + (dir, name) -> (name.endsWith(".pdf") || name.endsWith(".ai"))); for (File file : testFiles) {