From commits-return-15583-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Sat Aug 24 18:02:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D63A81804BB for ; Sat, 24 Aug 2019 20:02:14 +0200 (CEST) Received: (qmail 59887 invoked by uid 500); 24 Aug 2019 18:02:14 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 59878 invoked by uid 99); 24 Aug 2019 18:02:14 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Aug 2019 18:02:14 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 76FD63A38CC for ; Sat, 24 Aug 2019 18:02:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1865863 - in /pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger: streampane/tooltip/FontToolTip.java streampane/tooltip/KToolTip.java streampane/tooltip/SCNToolTip.java ui/textsearcher/SearchEngine.java Date: Sat, 24 Aug 2019 18:02:13 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190824180213.76FD63A38CC@svn01-us-west.apache.org> Author: tilman Date: Sat Aug 24 18:02:13 2019 New Revision: 1865863 URL: http://svn.apache.org/viewvc?rev=1865863&view=rev Log: PDFBOX-4071: improve logging Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/FontToolTip.java pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/KToolTip.java pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/SCNToolTip.java pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/textsearcher/SearchEngine.java Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/FontToolTip.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/FontToolTip.java?rev=1865863&r1=1865862&r2=1865863&view=diff ============================================================================== --- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/FontToolTip.java (original) +++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/FontToolTip.java Sat Aug 24 18:02:13 2019 @@ -18,6 +18,8 @@ package org.apache.pdfbox.debugger.streampane.tooltip; import java.io.IOException; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.pdfbox.cos.COSName; import org.apache.pdfbox.pdmodel.PDResources; import org.apache.pdfbox.pdmodel.font.PDFont; @@ -28,6 +30,7 @@ import org.apache.pdfbox.pdmodel.font.PD */ final class FontToolTip implements ToolTip { + private static final Log LOG = LogFactory.getLog(FontToolTip.class); private String markup; /** @@ -54,7 +57,7 @@ final class FontToolTip implements ToolT } catch (IOException e) { - e.printStackTrace(); + LOG.error(e.getMessage(), e); } } } Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/KToolTip.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/KToolTip.java?rev=1865863&r1=1865862&r2=1865863&view=diff ============================================================================== --- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/KToolTip.java (original) +++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/KToolTip.java Sat Aug 24 18:02:13 2019 @@ -23,6 +23,8 @@ import java.awt.color.ICC_Profile; import java.io.IOException; import java.io.InputStream; import java.net.URL; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.pdfbox.pdmodel.graphics.color.PDDeviceCMYK; /** @@ -30,8 +32,9 @@ import org.apache.pdfbox.pdmodel.graphic * A class that provide tooltip for K and k. */ final class KToolTip extends ColorToolTip - { + private static final Log LOG = LogFactory.getLog(KToolTip.class); + /** * Constructor. * @param rowText String instance. @@ -53,7 +56,7 @@ final class KToolTip extends ColorToolTi } catch (IOException e) { - e.printStackTrace(); + LOG.error(e.getMessage(), e); } } } Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/SCNToolTip.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/SCNToolTip.java?rev=1865863&r1=1865862&r2=1865863&view=diff ============================================================================== --- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/SCNToolTip.java (original) +++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/tooltip/SCNToolTip.java Sat Aug 24 18:02:13 2019 @@ -19,6 +19,8 @@ package org.apache.pdfbox.debugger.strea import java.awt.Color; import java.io.IOException; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.pdfbox.cos.COSName; import org.apache.pdfbox.pdmodel.PDResources; import org.apache.pdfbox.pdmodel.graphics.color.PDColorSpace; @@ -30,6 +32,8 @@ import org.apache.pdfbox.pdmodel.graphic */ final class SCNToolTip extends ColorToolTip { + private static final Log LOG = LogFactory.getLog(SCNToolTip.class); + /** * Constructor. * @param rowText String instance. @@ -48,7 +52,7 @@ final class SCNToolTip extends ColorTool } catch (IOException e) { - e.printStackTrace(); + LOG.error(e.getMessage(), e); } if (colorSpace instanceof PDPattern) { @@ -68,7 +72,7 @@ final class SCNToolTip extends ColorTool } catch (IOException e) { - e.printStackTrace(); + LOG.error(e.getMessage(), e); } } } Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/textsearcher/SearchEngine.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/textsearcher/SearchEngine.java?rev=1865863&r1=1865862&r2=1865863&view=diff ============================================================================== --- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/textsearcher/SearchEngine.java (original) +++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/textsearcher/SearchEngine.java Sat Aug 24 18:02:13 2019 @@ -23,6 +23,8 @@ import javax.swing.text.BadLocationExcep import javax.swing.text.Document; import javax.swing.text.Highlighter; import javax.swing.text.JTextComponent; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; /** * @author Khyrul Bashar @@ -30,6 +32,8 @@ import javax.swing.text.JTextComponent; */ class SearchEngine { + private static final Log LOG = LogFactory.getLog(SearchEngine.class); + private final Document document; private final Highlighter highlighter; private final Highlighter.HighlightPainter painter; @@ -73,7 +77,7 @@ class SearchEngine } catch (BadLocationException e) { - e.printStackTrace(); + LOG.error(e.getMessage(), e); return highlights; } if (!isCaseSensitive) @@ -97,7 +101,7 @@ class SearchEngine } catch (BadLocationException e) { - e.printStackTrace(); + LOG.error(e.getMessage(), e); } } }