From commits-return-15501-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Thu Aug 22 17:07:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4EC5180644 for ; Thu, 22 Aug 2019 19:07:34 +0200 (CEST) Received: (qmail 19798 invoked by uid 500); 22 Aug 2019 17:07:34 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 19789 invoked by uid 99); 22 Aug 2019 17:07:34 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Aug 2019 17:07:34 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id B80E83A3794 for ; Thu, 22 Aug 2019 17:07:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1865699 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java Date: Thu, 22 Aug 2019 17:07:33 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190822170733.B80E83A3794@svn01-us-west.apache.org> Author: tilman Date: Thu Aug 22 17:07:33 2019 New Revision: 1865699 URL: http://svn.apache.org/viewvc?rev=1865699&view=rev Log: PDFBOX-4071: SonarQube fix Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java?rev=1865699&r1=1865698&r2=1865699&view=diff ============================================================================== --- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java (original) +++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java Thu Aug 22 17:07:33 2019 @@ -206,6 +206,9 @@ final class FileSystemFontProvider exten { if (file.getName().toLowerCase().endsWith(".ttc")) { + @SuppressWarnings("squid:S2095") + // ttc not closed here because it is needed later when ttf is accessed, + // e.g. rendering PDF with non-embedded font which is in ttc file in our font directory TrueTypeCollection ttc = new TrueTypeCollection(file); TrueTypeFont ttf = ttc.getFontByName(postScriptName); if (ttf == null)