From commits-return-15372-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Tue Aug 13 17:37:37 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 274051804BB for ; Tue, 13 Aug 2019 19:37:37 +0200 (CEST) Received: (qmail 28382 invoked by uid 500); 13 Aug 2019 17:37:36 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 28373 invoked by uid 99); 13 Aug 2019 17:37:36 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Aug 2019 17:37:36 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 9C6C43A049F for ; Tue, 13 Aug 2019 17:37:35 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1865058 - /pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java Date: Tue, 13 Aug 2019 17:37:34 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190813173735.9C6C43A049F@svn01-us-west.apache.org> Author: tilman Date: Tue Aug 13 17:37:34 2019 New Revision: 1865058 URL: http://svn.apache.org/viewvc?rev=1865058&view=rev Log: PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski Modified: pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java Modified: pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java URL: http://svn.apache.org/viewvc/pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java?rev=1865058&r1=1865057&r2=1865058&view=diff ============================================================================== --- pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java (original) +++ pdfbox/branches/issue4569/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java Tue Aug 13 17:37:34 2019 @@ -1299,8 +1299,7 @@ public class PageDrawer extends PDFGraph PDAppearanceDictionary appearance = annotation.getAppearance(); if (appearance == null || appearance.getNormalAppearance() == null) { - // TODO: Improve memory consumption by passing a ScratchFile - annotation.constructAppearances(); + annotation.constructAppearances(renderer.document); } if (annotation.isNoRotate() && getCurrentPage().getRotation() != 0) {